From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
mrezanin@redhat.com,
"Richard Henderson" <richard.henderson@linaro.org>,
"Cédric Le Goater" <clegoate@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Jason J . Herne" <jjherne@linux.ibm.com>,
"Marc Hartmayer" <mhartmay@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Claudio Imbrenda" <imbrenda@linux.ibm.com>
Subject: [PATCH v2 2/4] pc-bios/s390-ccw: Provide space for initial stack frame in start.S
Date: Tue, 27 Jun 2023 09:47:01 +0200 [thread overview]
Message-ID: <20230627074703.99608-3-thuth@redhat.com> (raw)
In-Reply-To: <20230627074703.99608-1-thuth@redhat.com>
Providing the space of a stack frame is the duty of the caller,
so we should reserve 160 bytes before jumping into the main function.
Otherwise the main() function might write past the stack array.
While we're at it, add a proper STACK_SIZE macro for the stack size
instead of using magic numbers (this is also required for the following
patch).
Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/start.S | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index d29de09cc6..29b0a9ece0 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -10,10 +10,12 @@
* directory.
*/
+#define STACK_SIZE 0x8000
+
.globl _start
_start:
- larl %r15,stack + 0x8000 /* Set up stack */
+ larl %r15,stack + STACK_SIZE - 160 /* Set up stack */
/* clear bss */
larl %r2,__bss_start
--
2.39.3
next prev parent reply other threads:[~2023-06-27 7:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 7:46 [PATCH v2 0/4] pc-bios/s390-ccw: Fixes and improvements for start.S Thomas Huth
2023-06-27 7:47 ` [PATCH v2 1/4] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-27 9:15 ` Philippe Mathieu-Daudé
2023-06-27 9:27 ` Claudio Imbrenda
2023-06-27 10:01 ` Eric Farman
2023-06-27 7:47 ` Thomas Huth [this message]
2023-06-27 8:26 ` [PATCH v2 2/4] pc-bios/s390-ccw: Provide space for initial stack frame " Marc Hartmayer
2023-06-27 9:14 ` Philippe Mathieu-Daudé
2023-06-27 10:02 ` Eric Farman
2023-06-27 11:55 ` Thomas Huth
2023-06-27 9:27 ` Claudio Imbrenda
2023-06-27 7:47 ` [PATCH v2 3/4] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-27 9:28 ` Claudio Imbrenda
2023-06-27 10:14 ` Eric Farman
2023-06-27 15:47 ` Thomas Huth
2023-06-27 7:47 ` [PATCH v2 4/4] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction Thomas Huth
2023-06-27 9:29 ` Claudio Imbrenda
2023-06-27 10:54 ` Thomas Huth
2023-06-27 10:44 ` Eric Farman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230627074703.99608-3-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clegoate@redhat.com \
--cc=farman@linux.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=jjherne@linux.ibm.com \
--cc=mhartmay@linux.ibm.com \
--cc=mrezanin@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).