qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, "Riku Voipio" <riku.voipio@iki.fi>,
	"Leonardo Bras" <leobras@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Leif Lindholm" <quic_llindhol@quicinc.com>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	"Bandan Das" <bsd@redhat.com>, "Beraldo Leal" <bleal@redhat.com>,
	"Laurent Vivier" <laurent@vivier.eu>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Alexandre Iooss" <erdnaxe@crans.org>,
	"Juan Quintela" <quintela@redhat.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Qiuhao Li" <Qiuhao.Li@outlook.com>,
	"Mahmoud Mandour" <ma.mandourr@gmail.com>,
	"Peter Xu" <peterx@redhat.com>,
	"Radoslaw Biernacki" <rad@semihalf.com>,
	"Darren Kenny" <darren.kenny@oracle.com>,
	"Laurent Vivier" <lvivier@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alexander Bulekov" <alxndr@bu.edu>,
	"Ani Sinha" <anisinha@redhat.com>
Subject: [PATCH v3 04/36] docs/devel: remind developers to run CI container pipeline when updating images
Date: Tue, 27 Jun 2023 17:06:28 +0100	[thread overview]
Message-ID: <20230627160700.2955547-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230627160700.2955547-1-alex.bennee@linaro.org>

From: Ani Sinha <anisinha@redhat.com>

When new dependencies and packages are added to containers, its important to
run CI container generation pipelines on gitlab to make sure that there are no
obvious conflicts between packages that are being added and those that are
already present. Running CI container pipelines will make sure that there are
no such breakages before we commit the change updating the containers. Add a
line in the documentation reminding developers to run the pipeline before
submitting the change. It will also ease the life of the maintainers.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230506072012.10350-1-anisinha@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 docs/devel/testing.rst | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index 203facb417..8f18052ba7 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project:
    `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
    page on how to trigger gitlab CI pipelines on your change.
 
+ * Please also trigger gitlab container generation pipelines on your change
+   for as many OS distros as practical to make sure that there are no
+   obvious breakages when adding the new pre-requisite. Please see
+   `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
+   page on how to trigger gitlab CI pipelines on your change.
+
 For enterprise distros that default to old, end-of-life versions of the
 Python runtime, QEMU uses a separate set of mappings that work with more
 recent versions.  These can be found in ``tests/lcitool/mappings.yml``.
-- 
2.39.2



  parent reply	other threads:[~2023-06-27 16:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-27 16:06 [PATCH v3 00/36] maintainer omnibus: testing, fuzz, plugins, documentation (pre-PR) Alex Bennée
2023-06-27 16:06 ` [PATCH v3 01/36] gitlab: explicit set artifacts publishing criteria Alex Bennée
2023-06-27 16:06 ` [PATCH v3 02/36] gitlab: ensure coverage job also publishes meson log Alex Bennée
2023-06-27 16:06 ` [PATCH v3 03/36] gitlab: reduce testing scope of check-gcov Alex Bennée
2023-06-27 16:06 ` Alex Bennée [this message]
2023-06-27 16:06 ` [PATCH v3 05/36] tests/tcg: add mechanism to handle plugin arguments Alex Bennée
2023-06-27 16:06 ` [PATCH v3 06/36] qemu-keymap: properly check return from xkb_keymap_mod_get_index Alex Bennée
2023-06-27 16:06 ` [PATCH v3 07/36] scripts/oss-fuzz: add a suppression for keymap Alex Bennée
2023-06-27 16:06 ` [PATCH v3 08/36] tests/qtests: clean-up and fix leak in generic_fuzz Alex Bennée
2023-06-27 16:06 ` [PATCH v3 09/36] tests/docker: add test-fuzz Alex Bennée
2023-06-27 16:06 ` [PATCH v3 10/36] Makefile: add lcitool-refresh to UNCHECKED_GOALS Alex Bennée
2023-06-27 16:06 ` [PATCH v3 11/36] tests/lcitool: update to latest version Alex Bennée
2023-06-27 16:06 ` [PATCH v3 12/36] tests/lcitool: Bump fedora container versions Alex Bennée
2023-06-27 16:06 ` [PATCH v3 13/36] tests/lcitool: add an explicit gcc-native package Alex Bennée
2023-06-27 16:06 ` [PATCH v3 14/36] tests/lcitool: introduce qemu-minimal Alex Bennée
2023-06-27 16:06 ` [PATCH v3 15/36] tests/docker: convert riscv64-cross to lcitool Alex Bennée
2023-06-27 16:06 ` [PATCH v3 16/36] tests/avocado: update firmware to enable sbsa-ref/max Alex Bennée
2023-06-27 16:06 ` [PATCH v3 17/36] plugins: force slow path when plugins instrument memory ops Alex Bennée
2023-06-27 16:22 ` [PATCH v3 00/36] maintainer omnibus: testing, fuzz, plugins, documentation (pre-PR) Alex Bennée
  -- strict thread matches above, loose matches on Subject: below --
2023-06-27 16:09 [PATCH v3 00/36] maintainer omnibus: testing, fuzz, plugins, documentation, gdbstub (pre-PR) Alex Bennée
2023-06-27 16:09 ` [PATCH v3 04/36] docs/devel: remind developers to run CI container pipeline when updating images Alex Bennée
2023-06-29 13:42   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230627160700.2955547-5-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=Qiuhao.Li@outlook.com \
    --cc=alxndr@bu.edu \
    --cc=anisinha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=bmeng.cn@gmail.com \
    --cc=bsd@redhat.com \
    --cc=crosa@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=eduardo@habkost.net \
    --cc=erdnaxe@crans.org \
    --cc=laurent@vivier.eu \
    --cc=leobras@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=ma.mandourr@gmail.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=marcin.juszkiewicz@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=peterx@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quic_llindhol@quicinc.com \
    --cc=quintela@redhat.com \
    --cc=rad@semihalf.com \
    --cc=richard.henderson@linaro.org \
    --cc=riku.voipio@iki.fi \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    --cc=wangyanan55@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).