qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: "Fam Zheng" <fam@euphon.net>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	"Keith Busch" <kbusch@kernel.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-block@nongnu.org, "Hanna Reitz" <hreitz@redhat.com>,
	"Klaus Jensen" <its@irrelevant.dk>,
	"Minwoo Im" <minwoo.im@samsung.com>,
	"Klaus Jensen" <k.jensen@samsung.com>
Subject: [PULL 2/7] hw/nvme: consider COPY command in nvme_aio_err
Date: Wed, 28 Jun 2023 11:24:56 +0200	[thread overview]
Message-ID: <20230628092453.39602-11-its@irrelevant.dk> (raw)
In-Reply-To: <20230628092453.39602-9-its@irrelevant.dk>

From: Minwoo Im <minwoo.im@samsung.com>

If we don't have NVME_CMD_COPY consideration in the switch statement in
nvme_aio_err(), it will go to have NVME_INTERNAL_DEV_ERROR and
`req->status` will be ovewritten to it.  During the aio context, it
might set the NVMe status field like NVME_CMD_SIZE_LIMIT, but it's
overwritten in the nvme_aio_err().

Add consideration for the NVME_CMD_COPY not to overwrite the status at
the end of the function.

Signed-off-by: Minwoo Im <minwoo.im@samsung.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
 hw/nvme/ctrl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
index 020f37a780e0..e031c2250a84 100644
--- a/hw/nvme/ctrl.c
+++ b/hw/nvme/ctrl.c
@@ -1755,6 +1755,7 @@ static void nvme_aio_err(NvmeRequest *req, int ret)
     case NVME_CMD_WRITE:
     case NVME_CMD_WRITE_ZEROES:
     case NVME_CMD_ZONE_APPEND:
+    case NVME_CMD_COPY:
         status = NVME_WRITE_FAULT;
         break;
     default:
-- 
2.41.0



  parent reply	other threads:[~2023-06-28  9:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  9:24 [PULL 0/7] hw/nvme updates Klaus Jensen
2023-06-28  9:24 ` [PULL 1/7] hw/nvme: add comment for nvme-ns properties Klaus Jensen
2023-06-28  9:24 ` Klaus Jensen [this message]
2023-06-28  9:24 ` [PULL 3/7] hw/nvme: check maximum copy length (MCL) for COPY Klaus Jensen
2023-06-28  9:24 ` [PULL 4/7] hw/nvme: fix verification of number of ruhis Klaus Jensen
2023-06-28  9:24 ` [PULL 5/7] hw/nvme: verify uniqueness of reclaim unit handle identifiers Klaus Jensen
2023-06-28  9:25 ` [PULL 6/7] hw/nvme: add placement handle list ranges Klaus Jensen
2023-06-28  9:25 ` [PULL 7/7] docs: update hw/nvme documentation for TP4146 Klaus Jensen
2023-06-28 13:49 ` [PULL 0/7] hw/nvme updates Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230628092453.39602-11-its@irrelevant.dk \
    --to=its@irrelevant.dk \
    --cc=fam@euphon.net \
    --cc=hreitz@redhat.com \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=minwoo.im@samsung.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).