From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 22/23] block: use bdrv_co_getlength in coroutine context
Date: Wed, 28 Jun 2023 16:15:25 +0200 [thread overview]
Message-ID: <20230628141526.293104-23-kwolf@redhat.com> (raw)
In-Reply-To: <20230628141526.293104-1-kwolf@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
bdrv_co_getlength was recently introduced, with bdrv_getlength becoming
a wrapper for use in unknown context. Switch to bdrv_co_getlength when
possible.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <20230601115145.196465-12-pbonzini@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/io.c | 10 +++++-----
block/parallels.c | 4 ++--
block/qcow.c | 6 +++---
block/vmdk.c | 4 ++--
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/block/io.c b/block/io.c
index 30748f0b59..b53253c7a7 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1379,7 +1379,7 @@ bdrv_aligned_preadv(BdrvChild *child, BdrvTrackedRequest *req,
}
/* Forward the request to the BlockDriver, possibly fragmenting it */
- total_bytes = bdrv_getlength(bs);
+ total_bytes = bdrv_co_getlength(bs);
if (total_bytes < 0) {
ret = total_bytes;
goto out;
@@ -2388,7 +2388,7 @@ bdrv_co_block_status(BlockDriverState *bs, bool want_zero,
assert(pnum);
assert_bdrv_graph_readable();
*pnum = 0;
- total_size = bdrv_getlength(bs);
+ total_size = bdrv_co_getlength(bs);
if (total_size < 0) {
ret = total_size;
goto early_out;
@@ -2408,7 +2408,7 @@ bdrv_co_block_status(BlockDriverState *bs, bool want_zero,
bytes = n;
}
- /* Must be non-NULL or bdrv_getlength() would have failed */
+ /* Must be non-NULL or bdrv_co_getlength() would have failed */
assert(bs->drv);
has_filtered_child = bdrv_filter_child(bs);
if (!bs->drv->bdrv_co_block_status && !has_filtered_child) {
@@ -2546,7 +2546,7 @@ bdrv_co_block_status(BlockDriverState *bs, bool want_zero,
if (!cow_bs) {
ret |= BDRV_BLOCK_ZERO;
} else if (want_zero) {
- int64_t size2 = bdrv_getlength(cow_bs);
+ int64_t size2 = bdrv_co_getlength(cow_bs);
if (size2 >= 0 && offset >= size2) {
ret |= BDRV_BLOCK_ZERO;
@@ -3592,7 +3592,7 @@ int coroutine_fn bdrv_co_truncate(BdrvChild *child, int64_t offset, bool exact,
return ret;
}
- old_size = bdrv_getlength(bs);
+ old_size = bdrv_co_getlength(bs);
if (old_size < 0) {
error_setg_errno(errp, -old_size, "Failed to get old image size");
return old_size;
diff --git a/block/parallels.c b/block/parallels.c
index 7c263d5085..18e34aef28 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -200,7 +200,7 @@ allocate_clusters(BlockDriverState *bs, int64_t sector_num,
assert(idx < s->bat_size && idx + to_allocate <= s->bat_size);
space = to_allocate * s->tracks;
- len = bdrv_getlength(bs->file->bs);
+ len = bdrv_co_getlength(bs->file->bs);
if (len < 0) {
return len;
}
@@ -448,7 +448,7 @@ parallels_check_outside_image(BlockDriverState *bs, BdrvCheckResult *res,
uint32_t i;
int64_t off, high_off, size;
- size = bdrv_getlength(bs->file->bs);
+ size = bdrv_co_getlength(bs->file->bs);
if (size < 0) {
res->check_errors++;
return size;
diff --git a/block/qcow.c b/block/qcow.c
index 3644bbf5cb..cb240a5369 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -370,7 +370,7 @@ get_cluster_offset(BlockDriverState *bs, uint64_t offset, int allocate,
if (!allocate)
return 0;
/* allocate a new l2 entry */
- l2_offset = bdrv_getlength(bs->file->bs);
+ l2_offset = bdrv_co_getlength(bs->file->bs);
if (l2_offset < 0) {
return l2_offset;
}
@@ -445,7 +445,7 @@ get_cluster_offset(BlockDriverState *bs, uint64_t offset, int allocate,
if (decompress_cluster(bs, cluster_offset) < 0) {
return -EIO;
}
- cluster_offset = bdrv_getlength(bs->file->bs);
+ cluster_offset = bdrv_co_getlength(bs->file->bs);
if ((int64_t) cluster_offset < 0) {
return cluster_offset;
}
@@ -458,7 +458,7 @@ get_cluster_offset(BlockDriverState *bs, uint64_t offset, int allocate,
return ret;
}
} else {
- cluster_offset = bdrv_getlength(bs->file->bs);
+ cluster_offset = bdrv_co_getlength(bs->file->bs);
if ((int64_t) cluster_offset < 0) {
return cluster_offset;
}
diff --git a/block/vmdk.c b/block/vmdk.c
index 0410b895dc..234e671786 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -2132,7 +2132,7 @@ vmdk_co_pwritev_compressed(BlockDriverState *bs, int64_t offset, int64_t bytes,
int64_t length;
for (i = 0; i < s->num_extents; i++) {
- length = bdrv_getlength(s->extents[i].file->bs);
+ length = bdrv_co_getlength(s->extents[i].file->bs);
if (length < 0) {
return length;
}
@@ -2939,7 +2939,7 @@ vmdk_co_check(BlockDriverState *bs, BdrvCheckResult *result, BdrvCheckMode fix)
break;
}
if (ret == VMDK_OK) {
- int64_t extent_len = bdrv_getlength(extent->file->bs);
+ int64_t extent_len = bdrv_co_getlength(extent->file->bs);
if (extent_len < 0) {
fprintf(stderr,
"ERROR: could not get extent file length for sector %"
--
2.41.0
next prev parent reply other threads:[~2023-06-28 14:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 14:15 [PULL 00/23] Block layer patches Kevin Wolf
2023-06-28 14:15 ` [PULL 01/23] iotests: Test active commit with iothread and background I/O Kevin Wolf
2023-06-28 14:15 ` [PULL 02/23] qdev-properties-system: Lock AioContext for blk_insert_bs() Kevin Wolf
2023-06-28 14:15 ` [PULL 03/23] test-block-iothread: " Kevin Wolf
2023-06-28 14:15 ` [PULL 04/23] block: Fix AioContext locking in bdrv_open_child() Kevin Wolf
2023-06-28 14:15 ` [PULL 05/23] block: Fix AioContext locking in bdrv_attach_child_common() Kevin Wolf
2023-06-28 14:15 ` [PULL 06/23] block: Fix AioContext locking in bdrv_reopen_parse_file_or_backing() Kevin Wolf
2023-06-28 14:15 ` [PULL 07/23] block: Fix AioContext locking in bdrv_open_inherit() Kevin Wolf
2023-06-28 14:15 ` [PULL 08/23] block: Fix AioContext locking in bdrv_open_backing_file() Kevin Wolf
2023-06-28 14:15 ` [PULL 09/23] blockjob: Fix AioContext locking in block_job_add_bdrv() Kevin Wolf
2023-06-28 14:15 ` [PULL 10/23] graph-lock: Unlock the AioContext while polling Kevin Wolf
2023-06-28 14:15 ` [PULL 11/23] Revert "graph-lock: Disable locking for now" Kevin Wolf
2023-07-10 12:22 ` Klaus Jensen
2023-07-10 12:40 ` Kevin Wolf
2023-07-10 14:03 ` Klaus Jensen
2023-06-28 14:15 ` [PULL 12/23] file-posix: remove incorrect coroutine_fn calls Kevin Wolf
2023-06-28 14:15 ` [PULL 13/23] qed: mark more functions as coroutine_fns and GRAPH_RDLOCK Kevin Wolf
2023-06-28 14:15 ` [PULL 14/23] vpc: " Kevin Wolf
2023-06-28 14:15 ` [PULL 15/23] bochs: " Kevin Wolf
2023-06-28 14:15 ` [PULL 16/23] block: mark another function as coroutine_fns and GRAPH_UNLOCKED Kevin Wolf
2023-06-28 14:15 ` [PULL 17/23] cloop: mark more functions as coroutine_fns and GRAPH_RDLOCK Kevin Wolf
2023-06-28 14:15 ` [PULL 18/23] dmg: " Kevin Wolf
2023-06-28 14:15 ` [PULL 19/23] vmdk: " Kevin Wolf
2023-06-28 14:15 ` [PULL 20/23] vhdx: " Kevin Wolf
2023-06-28 14:15 ` [PULL 21/23] qcow2: " Kevin Wolf
2023-06-28 14:15 ` Kevin Wolf [this message]
2023-06-28 14:15 ` [PULL 23/23] block: use bdrv_co_debug_event in coroutine context Kevin Wolf
2023-06-29 6:11 ` [PULL 00/23] Block layer patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628141526.293104-23-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).