From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Eric Farman <farman@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: [PATCH v3 5/7] pc-bios/s390-ccw: Provide space for initial stack frame in start.S
Date: Thu, 29 Jun 2023 12:48:19 +0200 [thread overview]
Message-ID: <20230629104821.194859-6-thuth@redhat.com> (raw)
In-Reply-To: <20230629104821.194859-1-thuth@redhat.com>
Providing the space of a stack frame is the duty of the caller,
so we should reserve 160 bytes before jumping into the main function.
Otherwise the main() function might write past the stack array.
While we're at it, add a proper STACK_SIZE macro for the stack size
instead of using magic numbers (this is also required for the following
patch).
Reviewed-by: Christian Borntraeger <borntraeger@linux.ibm.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Message-Id: <20230627074703.99608-3-thuth@redhat.com>
Reviewed-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/start.S | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/pc-bios/s390-ccw/start.S b/pc-bios/s390-ccw/start.S
index d29de09cc6..abd6fe6639 100644
--- a/pc-bios/s390-ccw/start.S
+++ b/pc-bios/s390-ccw/start.S
@@ -10,10 +10,13 @@
* directory.
*/
+#define STACK_SIZE 0x8000
+#define STACK_FRAME_SIZE 160
+
.globl _start
_start:
- larl %r15,stack + 0x8000 /* Set up stack */
+ larl %r15,stack + STACK_SIZE - STACK_FRAME_SIZE /* Set up stack */
/* clear bss */
larl %r2,__bss_start
--
2.39.3
next prev parent reply other threads:[~2023-06-29 10:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 10:48 [PATCH v3 0/7] pc-bios/s390-ccw: Fixes and improvements for start.S (and other files) Thomas Huth
2023-06-29 10:48 ` [PATCH v3 1/7] s390-ccw: Getting rid of ulong Thomas Huth
2023-06-29 11:01 ` Claudio Imbrenda
2023-06-29 11:12 ` Philippe Mathieu-Daudé
2023-06-29 10:48 ` [PATCH v3 2/7] pc-bios/s390-ccw: Get rid of the the __u* types Thomas Huth
2023-06-29 10:48 ` [PATCH v3 3/7] pc-bios/s390-ccw/Makefile: Use -z noexecstack to silence linker warning Thomas Huth
2023-06-29 10:48 ` [PATCH v3 4/7] pc-bios/s390-ccw: Fix indentation in start.S Thomas Huth
2023-06-29 10:48 ` Thomas Huth [this message]
2023-06-29 10:48 ` [PATCH v3 6/7] pc-bios/s390-ccw: Move the stack array into start.S Thomas Huth
2023-06-29 10:48 ` [PATCH v3 7/7] pc-bios/s390-ccw: Don't use __bss_start with the "larl" instruction Thomas Huth
2023-06-29 10:58 ` Claudio Imbrenda
2023-06-29 11:12 ` Thomas Huth
2023-06-29 11:25 ` Claudio Imbrenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230629104821.194859-6-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=farman@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).