From: Joel Stanley <joel@jms.id.au>
To: "Cédric Le Goater" <clg@kaod.org>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: [PATCH 0/4] ppc/pnv: Extend "quad" model for p10
Date: Fri, 30 Jun 2023 13:25:43 +0930 [thread overview]
Message-ID: <20230630035547.80329-1-joel@jms.id.au> (raw)
The quad model implements the EC xscoms for the p9 machine, reusing the
same model for p10 which isn't quite correct. This series adds a PnvQuad
class and subclasses it for P9 and P10. Implement the core thread state
xscom as an example. I expect more function to be implemented in future
patches.
There's one outstanding question. Skiboot has this for the p10 scom:
#define P10_EC_CORE_THREAD_STATE 0x412
However the read that comes is for 0x28412. I suspect the upper 0x28000
are addressing bits, so we're really reporting the core thread state for
the given core. Should the model instead wired so one is created for
each chiplet? Or should we report the value for all possible cores, like
the P9 code does for P9X_EX_NCU_SPEC_BAR?
switch (offset) {
case P9X_EX_NCU_SPEC_BAR:
case P9X_EX_NCU_SPEC_BAR + 0x400: /* Second EX */
Joel Stanley (4):
ppc/pnv: quad xscom callbacks are P9 specific
ppc/pnv: Subclass quad xscom callbacks
ppc/pnv: Add P10 quad ops
ppc/pnv: Return zero for core thread state xscom
include/hw/ppc/pnv_core.h | 12 +++-
hw/ppc/pnv.c | 11 ++--
hw/ppc/pnv_core.c | 114 +++++++++++++++++++++++++++++++-------
3 files changed, 113 insertions(+), 24 deletions(-)
--
2.40.1
next reply other threads:[~2023-06-30 3:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 3:55 Joel Stanley [this message]
2023-06-30 3:55 ` [PATCH 1/4] ppc/pnv: quad xscom callbacks are P9 specific Joel Stanley
2023-06-30 5:23 ` Cédric Le Goater
2023-06-30 3:55 ` [PATCH 2/4] ppc/pnv: Subclass quad xscom callbacks Joel Stanley
2023-06-30 5:24 ` Cédric Le Goater
2023-06-30 3:55 ` [PATCH 3/4] ppc/pnv: Add P10 quad ops Joel Stanley
2023-06-30 5:24 ` Cédric Le Goater
2023-06-30 7:30 ` Frederic Barrat
2023-06-30 7:35 ` Joel Stanley
2023-06-30 7:44 ` Cédric Le Goater
2023-06-30 13:47 ` Daniel Henrique Barboza
2023-06-30 3:55 ` [PATCH 4/4] ppc/pnv: Return zero for core thread state xscom Joel Stanley
2023-06-30 5:24 ` Cédric Le Goater
2023-07-01 10:22 ` Nicholas Piggin
2023-07-01 10:10 ` [PATCH 0/4] ppc/pnv: Extend "quad" model for p10 Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630035547.80329-1-joel@jms.id.au \
--to=joel@jms.id.au \
--cc=clg@kaod.org \
--cc=fbarrat@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).