From: "Michael S. Tsirkin" <mst@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Ani Sinha <anisinha@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
Jason Wang <jasowang@redhat.com>, Keith Busch <kbusch@kernel.org>,
Klaus Jensen <its@irrelevant.dk>
Subject: Re: [PATCH 0/4] pci: Compare function number and ARI next function number
Date: Sun, 2 Jul 2023 01:10:05 -0400 [thread overview]
Message-ID: <20230702010655-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230701070133.24877-1-akihiko.odaki@daynix.com>
On Sat, Jul 01, 2023 at 04:01:18PM +0900, Akihiko Odaki wrote:
> The function number must be lower than the next function number
> advertised with ARI. Add a check to enforce this.
>
> I suggested this change at:
> https://lore.kernel.org/qemu-devel/bf351f8b-1c8a-8a7a-7f44-17c9ba18f179@daynix.com/
>
> Implementing this change, I found the devices implementing ARI do not set the
> correct next function numbers, which is also fixed in this series.
This isn't going to be merged with more in the way of motivation.
Analysis of at least linux guest behavious, documentation about testing,
addressing migration concerns are all not there either.
> Akihiko Odaki (4):
> docs: Fix next function numbers in SR/IOV documentation
> hw/nvme: Fix ARI next function numbers
> igb: Fix ARI next function numbers
> pci: Compare function number and ARI next function number
>
> docs/pcie_sriov.txt | 5 +++--
> hw/net/igb_core.h | 3 +++
> hw/net/igb.c | 4 +---
> hw/net/igbvf.c | 5 ++++-
> hw/nvme/ctrl.c | 7 ++++++-
> hw/pci/pci.c | 15 +++++++++++++++
> 6 files changed, 32 insertions(+), 7 deletions(-)
>
> --
> 2.41.0
prev parent reply other threads:[~2023-07-02 5:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-01 7:01 [PATCH 0/4] pci: Compare function number and ARI next function number Akihiko Odaki
2023-07-01 7:01 ` [PATCH 1/4] docs: Fix next function numbers in SR/IOV documentation Akihiko Odaki
2023-07-01 14:31 ` Ani Sinha
2023-07-02 3:51 ` Akihiko Odaki
2023-07-01 7:01 ` [PATCH 2/4] hw/nvme: Fix ARI next function numbers Akihiko Odaki
2023-07-01 7:01 ` [PATCH 3/4] igb: " Akihiko Odaki
2023-07-02 5:05 ` Michael S. Tsirkin
2023-07-02 8:38 ` Akihiko Odaki
2023-07-02 8:40 ` Michael S. Tsirkin
2023-07-01 7:01 ` [PATCH 4/4] pci: Compare function number and ARI next function number Akihiko Odaki
2023-07-02 4:58 ` Michael S. Tsirkin
2023-07-02 8:46 ` Akihiko Odaki
2023-07-02 8:55 ` Michael S. Tsirkin
2023-07-02 8:57 ` Michael S. Tsirkin
2023-07-11 7:10 ` Ani Sinha
2023-07-11 8:33 ` Michael S. Tsirkin
2023-07-02 5:10 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230702010655-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=anisinha@redhat.com \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=kbusch@kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sriram.yagnaraman@est.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).