qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhenzhong Duan <zhenzhong.duan@intel.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, clg@redhat.com,
	joao.m.martins@oracle.com, avihaih@nvidia.com,
	chao.p.peng@intel.com
Subject: [PATCH v6 3/7] vfio/pci: Disable INTx in vfio_realize error path
Date: Mon,  3 Jul 2023 15:15:06 +0800	[thread overview]
Message-ID: <20230703071510.160712-2-zhenzhong.duan@intel.com> (raw)
In-Reply-To: <20230703071510.160712-1-zhenzhong.duan@intel.com>

When vfio realize fails, INTx isn't disabled if it has been enabled.
This may confuse host side with unhandled interrupt report.

Fixes: c5478fea27ac ("vfio/pci: Respond to KVM irqchip change notifier")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
---
 hw/vfio/pci.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index ab6645ba60af..31c4ab250fbe 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -3220,6 +3220,9 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
     return;
 
 out_deregister:
+    if (vdev->interrupt == VFIO_INT_INTx) {
+        vfio_intx_disable(vdev);
+    }
     pci_device_set_intx_routing_notifier(&vdev->pdev, NULL);
     if (vdev->irqchip_change_notifier.notify) {
         kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier);
-- 
2.34.1



  reply	other threads:[~2023-07-03  7:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03  7:15 [PATCH v6 0/7] VFIO migration related refactor and bug fix Zhenzhong Duan
2023-07-03  7:15 ` Zhenzhong Duan [this message]
2023-07-03  7:15 ` [PATCH v6 4/7] vfio/migration: Change vIOMMU blocker from global to per device Zhenzhong Duan
2023-07-03 14:57   ` Cédric Le Goater
2023-07-03  7:15 ` [PATCH v6 5/7] vfio/migration: Free resources when vfio_migration_realize fails Zhenzhong Duan
2023-07-03 15:23   ` Joao Martins
2023-07-03 15:34   ` Avihai Horon
2023-07-03 15:41     ` Cédric Le Goater
2023-07-03 15:44   ` Cédric Le Goater
2023-07-04  1:56     ` Duan, Zhenzhong
2023-07-04  1:33   ` Duan, Zhenzhong
2023-07-03  7:15 ` [PATCH v6 6/7] vfio/migration: Remove print of "Migration disabled" Zhenzhong Duan
2023-07-03 14:58   ` Cédric Le Goater
2023-07-03  7:15 ` [PATCH v6 7/7] vfio/migration: Return bool type for vfio_migration_realize() Zhenzhong Duan
2023-07-03 14:58   ` Cédric Le Goater
2023-07-03 15:24   ` Joao Martins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703071510.160712-2-zhenzhong.duan@intel.com \
    --to=zhenzhong.duan@intel.com \
    --cc=alex.williamson@redhat.com \
    --cc=avihaih@nvidia.com \
    --cc=chao.p.peng@intel.com \
    --cc=clg@redhat.com \
    --cc=joao.m.martins@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).