qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, "Ani Sinha" <anisinha@redhat.com>,
	"Daniel P . Berrangé" <berrange@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PULL 04/38] docs/devel: remind developers to run CI container pipeline when updating images
Date: Mon,  3 Jul 2023 14:43:53 +0100	[thread overview]
Message-ID: <20230703134427.1389440-5-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230703134427.1389440-1-alex.bennee@linaro.org>

From: Ani Sinha <anisinha@redhat.com>

When new dependencies and packages are added to containers, its important to
run CI container generation pipelines on gitlab to make sure that there are no
obvious conflicts between packages that are being added and those that are
already present. Running CI container pipelines will make sure that there are
no such breakages before we commit the change updating the containers. Add a
line in the documentation reminding developers to run the pipeline before
submitting the change. It will also ease the life of the maintainers.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20230506072012.10350-1-anisinha@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230630180423.558337-5-alex.bennee@linaro.org>

diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst
index e85e26c4ca..fb651eae11 100644
--- a/docs/devel/testing.rst
+++ b/docs/devel/testing.rst
@@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project:
    `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
    page on how to trigger gitlab CI pipelines on your change.
 
+ * Please also trigger gitlab container generation pipelines on your change
+   for as many OS distros as practical to make sure that there are no
+   obvious breakages when adding the new pre-requisite. Please see
+   `CI <https://www.qemu.org/docs/master/devel/ci.html>`__ documentation
+   page on how to trigger gitlab CI pipelines on your change.
+
 For enterprise distros that default to old, end-of-life versions of the
 Python runtime, QEMU uses a separate set of mappings that work with more
 recent versions.  These can be found in ``tests/lcitool/mappings.yml``.
-- 
2.39.2



  parent reply	other threads:[~2023-07-03 13:52 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 13:43 [PULL 00/38] maintainer updates for 8.1: testing, fuzz, plugins, docs, gdbstub Alex Bennée
2023-07-03 13:43 ` [PULL 01/38] gitlab: explicit set artifacts publishing criteria Alex Bennée
2023-07-03 13:43 ` [PULL 02/38] gitlab: ensure coverage job also publishes meson log Alex Bennée
2023-07-03 13:43 ` [PULL 03/38] gitlab: reduce testing scope of check-gcov Alex Bennée
2023-07-03 13:43 ` Alex Bennée [this message]
2023-07-03 13:43 ` [PULL 05/38] tests/tcg: add mechanism to handle plugin arguments Alex Bennée
2023-07-03 13:43 ` [PULL 06/38] qemu-keymap: properly check return from xkb_keymap_mod_get_index Alex Bennée
2023-07-03 13:43 ` [PULL 07/38] scripts/oss-fuzz: add a suppression for keymap Alex Bennée
2023-07-03 13:43 ` [PULL 08/38] tests/qtests: clean-up and fix leak in generic_fuzz Alex Bennée
2023-07-03 13:43 ` [PULL 09/38] tests/docker: add test-fuzz Alex Bennée
2023-07-03 13:43 ` [PULL 10/38] Makefile: add lcitool-refresh to UNCHECKED_GOALS Alex Bennée
2023-07-03 13:44 ` [PULL 11/38] tests/lcitool: update to latest version Alex Bennée
2023-07-03 13:44 ` [PULL 12/38] tests/lcitool: Bump fedora container versions Alex Bennée
2023-07-03 13:44 ` [PULL 13/38] tests/lcitool: add an explicit gcc-native package Alex Bennée
2023-07-03 13:44 ` [PULL 14/38] tests/lcitool: introduce qemu-minimal Alex Bennée
2023-07-03 13:44 ` [PULL 15/38] tests/docker: convert riscv64-cross to lcitool Alex Bennée
2023-07-03 13:44 ` [PULL 16/38] tests/avocado: update firmware to enable sbsa-ref/max Alex Bennée
2023-07-03 13:44 ` [PULL 17/38] tests/avocado: Make the test_arm_bpim2u_gmac test more reliable Alex Bennée
2023-07-03 13:44 ` [PULL 18/38] target/arm: make arm_casq_ptw CONFIG_TCG only Alex Bennée
2023-07-03 13:44 ` [PULL 19/38] plugins: force slow path when plugins instrument memory ops Alex Bennée
2023-07-03 13:44 ` [PULL 20/38] plugins: fix memory leak while parsing options Alex Bennée
2023-07-03 13:44 ` [PULL 21/38] plugins: update lockstep to use g_memdup2 Alex Bennée
2023-11-13 10:46   ` Thomas Huth
2023-11-13 11:40     ` Alex Bennée
2023-11-13 11:55       ` Daniel P. Berrangé
2023-11-13 12:21       ` Thomas Huth
2023-07-03 13:44 ` [PULL 22/38] docs/devel: add some front matter to the devel index Alex Bennée
2023-07-03 13:44 ` [PULL 23/38] include/migration: mark vmstate_register() as a legacy function Alex Bennée
2023-07-03 13:44 ` [PULL 24/38] include/hw/qdev-core: fixup kerneldoc annotations Alex Bennée
2023-07-03 13:44 ` [PULL 25/38] docs/devel/qom.rst: Correct code style Alex Bennée
2023-07-03 13:44 ` [PULL 26/38] docs/devel: split qom-api reference into new file Alex Bennée
2023-07-03 13:44 ` [PULL 27/38] docs/devel: introduce some key concepts for QOM development Alex Bennée
2023-07-03 13:44 ` [PULL 28/38] gdbstub: lightly refactor connection to avoid snprintf Alex Bennée
2023-07-03 13:44 ` [PULL 29/38] gdbstub: Permit reverse step/break to provide stop response Alex Bennée
2023-07-08  6:17   ` Michael Tokarev
2023-07-08 10:10     ` Alex Bennée
2023-07-09  8:12       ` Michael Tokarev
2023-07-03 13:44 ` [PULL 30/38] gdbstub: clean-up vcont handling to avoid goto Alex Bennée
2023-07-03 13:44 ` [PULL 31/38] linux-user: Expose do_guest_openat() and do_guest_readlink() Alex Bennée
2023-07-03 13:44 ` [PULL 32/38] linux-user: Add "safe" parameter to do_guest_openat() Alex Bennée
2023-07-03 13:44 ` [PULL 33/38] linux-user: Emulate /proc/self/smaps Alex Bennée
2023-07-03 13:44 ` [PULL 34/38] gdbstub: Expose gdb_get_process() and gdb_get_first_cpu_in_process() Alex Bennée
2023-07-03 13:44 ` [PULL 35/38] gdbstub: Report the actual qemu-user pid Alex Bennée
2023-07-03 13:44 ` [PULL 36/38] gdbstub: Add support for info proc mappings Alex Bennée
2023-07-03 13:44 ` [PULL 37/38] docs: Document security implications of debugging Alex Bennée
2023-07-03 13:44 ` [PULL 38/38] tests/tcg: Add a test for info proc mappings Alex Bennée
2023-07-04  8:19 ` [PULL 00/38] maintainer updates for 8.1: testing, fuzz, plugins, docs, gdbstub Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703134427.1389440-5-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=anisinha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).