From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>
Subject: [PATCH 12/12] tests/tcg/s390x: Test MVCRL with a large value in R0
Date: Mon, 3 Jul 2023 17:50:38 +0200 [thread overview]
Message-ID: <20230703155801.179167-13-iii@linux.ibm.com> (raw)
In-Reply-To: <20230703155801.179167-1-iii@linux.ibm.com>
Add a small test to prevent regressions.
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
tests/tcg/s390x/mie3-mvcrl.c | 46 ++++++++++++++++++++++++++++--------
1 file changed, 36 insertions(+), 10 deletions(-)
diff --git a/tests/tcg/s390x/mie3-mvcrl.c b/tests/tcg/s390x/mie3-mvcrl.c
index 93c7b0a2903..ec78dd1d493 100644
--- a/tests/tcg/s390x/mie3-mvcrl.c
+++ b/tests/tcg/s390x/mie3-mvcrl.c
@@ -1,29 +1,55 @@
+#include <stdbool.h>
#include <stdint.h>
+#include <stdlib.h>
#include <string.h>
-
-static inline void mvcrl_8(const char *dst, const char *src)
+static void mvcrl(const char *dst, const char *src, size_t len)
{
+ register long r0 asm("r0") = len;
+
asm volatile (
- "llill %%r0, 8\n"
".insn sse, 0xE50A00000000, 0(%[dst]), 0(%[src])"
- : : [dst] "d" (dst), [src] "d" (src)
- : "r0", "memory");
+ : : [dst] "d" (dst), [src] "d" (src), "r" (r0)
+ : "memory");
}
-
-int main(int argc, char *argv[])
+static bool test(void)
{
const char *alpha = "abcdefghijklmnop";
/* array missing 'i' */
- char tstr[17] = "abcdefghjklmnop\0" ;
+ char tstr[17] = "abcdefghjklmnop\0";
/* mvcrl reference use: 'open a hole in an array' */
- mvcrl_8(tstr + 9, tstr + 8);
+ mvcrl(tstr + 9, tstr + 8, 8);
/* place missing 'i' */
tstr[8] = 'i';
- return strncmp(alpha, tstr, 16ul);
+ return strncmp(alpha, tstr, 16ul) == 0;
+}
+
+static bool test_bad_r0(void)
+{
+ char src[256];
+
+ /*
+ * PoP says: Bits 32-55 of general register 0 should contain zeros;
+ * otherwise, the program may not operate compatibly in the future.
+ *
+ * Try it anyway in order to check whether this would crash QEMU itself.
+ */
+ mvcrl(src, src, (size_t)-1);
+
+ return true;
+}
+
+int main(void)
+{
+ bool ok = true;
+
+ ok &= test();
+ ok &= test_bad_r0();
+
+ return ok ? EXIT_SUCCESS : EXIT_FAILURE;
}
--
2.41.0
next prev parent reply other threads:[~2023-07-03 15:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 15:50 [PATCH 00/12] target/s390x: Miscellaneous TCG fixes Ilya Leoshkevich
2023-07-03 15:50 ` [PATCH 01/12] linux-user: elfload: Add more initial s390x PSW bits Ilya Leoshkevich
2023-07-04 7:32 ` David Hildenbrand
2023-07-04 7:40 ` Ilya Leoshkevich
2023-07-04 7:48 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 02/12] target/s390x: Fix EPSW CC reporting Ilya Leoshkevich
2023-07-04 7:38 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 03/12] target/s390x: Fix MDEB and MDEBR Ilya Leoshkevich
2023-07-04 7:40 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 04/12] target/s390x: Fix MVCRL with a large value in R0 Ilya Leoshkevich
2023-07-04 7:40 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 05/12] target/s390x: Fix LRA overwriting the top 32 bits on DAT error Ilya Leoshkevich
2023-07-04 7:47 ` David Hildenbrand
2023-07-04 8:05 ` Ilya Leoshkevich
2023-07-04 8:06 ` Richard Henderson
2023-07-04 8:14 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 06/12] target/s390x: Fix LRA when DAT is off Ilya Leoshkevich
2023-07-04 7:53 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 07/12] target/s390x: Fix relative long instructions with large offsets Ilya Leoshkevich
2023-07-04 7:54 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 08/12] tests/tcg/s390x: Test EPSW Ilya Leoshkevich
2023-07-04 7:55 ` David Hildenbrand
2023-07-03 15:50 ` [PATCH 09/12] tests/tcg/s390x: Test LARL with a large offset Ilya Leoshkevich
2023-07-04 7:56 ` David Hildenbrand
2023-07-04 7:59 ` Ilya Leoshkevich
2023-07-03 15:50 ` [PATCH 10/12] tests/tcg/s390x: Test LRA Ilya Leoshkevich
2023-07-03 15:50 ` [PATCH 11/12] tests/tcg/s390x: Test MDEB and MDEBR Ilya Leoshkevich
2023-07-04 7:58 ` David Hildenbrand
2023-07-03 15:50 ` Ilya Leoshkevich [this message]
2023-07-04 7:59 ` [PATCH 12/12] tests/tcg/s390x: Test MVCRL with a large value in R0 David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230703155801.179167-13-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).