From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Laurent Vivier <laurent@vivier.eu>,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org, qemu-s390x@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-stable@nongnu.org
Subject: [PATCH v2 02/12] target/s390x: Fix EPSW CC reporting
Date: Tue, 4 Jul 2023 10:12:26 +0200 [thread overview]
Message-ID: <20230704081506.276055-3-iii@linux.ibm.com> (raw)
In-Reply-To: <20230704081506.276055-1-iii@linux.ibm.com>
EPSW should explicitly calculate and insert CC, like IPM does.
Fixes: e30a9d3fea58 ("target-s390: Implement EPSW")
Cc: qemu-stable@nongnu.org
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/translate.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index a6ee2d44234..0cef6efbef4 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -2383,10 +2383,14 @@ static DisasJumpType op_epsw(DisasContext *s, DisasOps *o)
int r1 = get_field(s, r1);
int r2 = get_field(s, r2);
TCGv_i64 t = tcg_temp_new_i64();
+ TCGv_i64 t_cc = tcg_temp_new_i64();
/* Note the "subsequently" in the PoO, which implies a defined result
if r1 == r2. Thus we cannot defer these writes to an output hook. */
+ gen_op_calc_cc(s);
+ tcg_gen_extu_i32_i64(t_cc, cc_op);
tcg_gen_shri_i64(t, psw_mask, 32);
+ tcg_gen_deposit_i64(t, t, t_cc, 12, 2);
store_reg32_i64(r1, t);
if (r2 != 0) {
store_reg32_i64(r2, psw_mask);
--
2.41.0
next prev parent reply other threads:[~2023-07-04 8:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 8:12 [PATCH v2 00/12] target/s390x: Miscellaneous TCG fixes Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 01/12] linux-user: elfload: Add more initial s390x PSW bits Ilya Leoshkevich
2023-07-04 8:12 ` Ilya Leoshkevich [this message]
2023-07-04 8:12 ` [PATCH v2 03/12] target/s390x: Fix MDEB and MDEBR Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 04/12] target/s390x: Fix MVCRL with a large value in R0 Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 05/12] target/s390x: Fix LRA overwriting the top 32 bits on DAT error Ilya Leoshkevich
2023-07-04 8:16 ` David Hildenbrand
2023-07-04 8:12 ` [PATCH v2 06/12] target/s390x: Fix LRA when DAT is off Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 07/12] target/s390x: Fix relative long instructions with large offsets Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 08/12] tests/tcg/s390x: Test EPSW Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 09/12] tests/tcg/s390x: Test LARL with a large offset Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 10/12] tests/tcg/s390x: Test LRA Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 11/12] tests/tcg/s390x: Test MDEB and MDEBR Ilya Leoshkevich
2023-07-04 8:12 ` [PATCH v2 12/12] tests/tcg/s390x: Test MVCRL with a large value in R0 Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230704081506.276055-3-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).