qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <anisinha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ani Sinha <anisinha@redhat.com>,
	mst@redhat.com, imammedo@redhat.com, jusual@redhat.com,
	thuth@redhat.com, lvivier@redhat.com,
	michael.labiuk@virtuozzo.com
Subject: [PATCH v8 0/6] test and QEMU fixes to ensure proper PCIE device usage
Date: Wed,  5 Jul 2023 17:29:18 +0530	[thread overview]
Message-ID: <20230705115925.5339-1-anisinha@redhat.com> (raw)

Patches 1-4:
Fix tests so that devices do not use non-zero slots on the pcie root
ports. PCIE ports only have one slot, so PCIE devices can only be
plugged into slot 0 on a PCIE port.

Patch 5:
Enforce only one slot on PCIE port.

Patch 6: add a cosmetic comment addition for better clarity of the code.

The test fixes must be applied before the QEMU change that checks for use
of a single slot in PCIE port.

CC: mst@redhat.com
CC: imammedo@redhat.com
CC: jusual@redhat.com
CC: thuth@redhat.com
CC: lvivier@redhat.com
CC: michael.labiuk@virtuozzo.com

Changelog:
===========
v8: more comment messaging. rebased to latest master. small changes in patch
description and title.

v7: added tags, rebased to latest master.
For patch 5, converted a hard error to a warning.
Added patch 6.

v6: make patch 5 ARI compliant. fix commit message (s/pcie-root-port/pcie-to-pci/)
in patch 4. Rebase patchset to latest master.

v5: no code changes - correct a mistake in the commit log message.

v4: reword commit log for patch 4.

v3: tags added. reword the error description in patch 5. Reword commit log in patch 4. 

v2: add hd-geo-test fix as well as the actual QEMU code fix to the patchset.

The patches are added in the right order.

Ani Sinha (6):
  tests/acpi: allow changes in DSDT.noacpihp table blob
  tests/acpi/bios-tables-test: use the correct slot on the
    pcie-root-port
  tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp
  tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and
    simplify test
  hw/pci: warn when PCIe device is plugged into non-zero slot of
    downstream port
  hw/pci: add comment to explain checking for available function 0 in
    pci hotplug

 hw/pci/pci.c                      |  31 +++++++++++++++++++++++++++---
 tests/data/acpi/q35/DSDT.noacpihp | Bin 8248 -> 8241 bytes
 tests/qtest/bios-tables-test.c    |   4 ++--
 tests/qtest/hd-geo-test.c         |  18 ++++++++---------
 4 files changed, 38 insertions(+), 15 deletions(-)

-- 
2.39.1



             reply	other threads:[~2023-07-05 12:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 11:59 Ani Sinha [this message]
2023-07-05 11:59 ` [PATCH v8 1/6] tests/acpi: allow changes in DSDT.noacpihp table blob Ani Sinha
2023-07-05 11:59 ` [PATCH v8 2/6] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port Ani Sinha
2023-07-05 11:59 ` [PATCH v8 3/6] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp Ani Sinha
2023-07-05 11:59 ` [PATCH v8 4/6] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test Ani Sinha
2023-07-05 11:59 ` [PATCH v8 5/6] hw/pci: warn when PCIe device is plugged into non-zero slot of downstream port Ani Sinha
2023-07-06  1:48   ` Akihiko Odaki
2023-07-05 11:59 ` [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug Ani Sinha
2023-07-05 12:03   ` Ani Sinha
2023-07-10 19:43     ` Michael S. Tsirkin
2023-07-11  3:46       ` Ani Sinha
2023-07-11  3:51         ` Michael Tokarev
2023-07-11  4:03           ` Ani Sinha
2023-07-11  4:13             ` Michael Tokarev
2023-07-11  4:36               ` Ani Sinha
2023-07-05 11:59 ` [PATCH v8 6/6] hw/pci: add comment to explain checking for available function 0 in pci hotplug Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230705115925.5339-1-anisinha@redhat.com \
    --to=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jusual@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=michael.labiuk@virtuozzo.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).