qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ani Sinha <anisinha@redhat.com>
To: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Ani Sinha <anisinha@redhat.com>
Subject: [PATCH v8 2/6] tests/acpi/bios-tables-test: use the correct slot on the pcie-root-port
Date: Wed,  5 Jul 2023 17:29:20 +0530	[thread overview]
Message-ID: <20230705115925.5339-3-anisinha@redhat.com> (raw)
In-Reply-To: <20230705115925.5339-1-anisinha@redhat.com>

PCIE ports only have one slot, slot 0. Hence, non-zero slots are not available
for PCIE devices on PCIE root ports. Fix test_acpi_q35_tcg_no_acpi_hotplug()
so that the test does not use them.

Signed-off-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
 tests/qtest/bios-tables-test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index ed1c69cf01..47ba20b957 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1020,9 +1020,9 @@ static void test_acpi_q35_tcg_no_acpi_hotplug(void)
         " -device pci-testdev,bus=nohprp,acpi-index=501"
         " -device pcie-root-port,id=nohprpint,port=0x0,chassis=3,hotplug=off,"
                                  "multifunction=on,addr=8.0"
-        " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=8.1"
+        " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=0.1"
         " -device pcie-root-port,id=hprp2,port=0x0,chassis=4,bus=nohprpint,"
-                                 "addr=9.0"
+                                 "addr=0.2"
         " -device pci-testdev,bus=hprp2,acpi-index=602"
         , &data);
     free_test_data(&data);
-- 
2.39.1



  parent reply	other threads:[~2023-07-05 12:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-05 11:59 [PATCH v8 0/6] test and QEMU fixes to ensure proper PCIE device usage Ani Sinha
2023-07-05 11:59 ` [PATCH v8 1/6] tests/acpi: allow changes in DSDT.noacpihp table blob Ani Sinha
2023-07-05 11:59 ` Ani Sinha [this message]
2023-07-05 11:59 ` [PATCH v8 3/6] tests/acpi/bios-tables-test: update acpi blob q35/DSDT.noacpihp Ani Sinha
2023-07-05 11:59 ` [PATCH v8 4/6] tests/qtest/hd-geo-test: fix incorrect pcie-root-port usage and simplify test Ani Sinha
2023-07-05 11:59 ` [PATCH v8 5/6] hw/pci: warn when PCIe device is plugged into non-zero slot of downstream port Ani Sinha
2023-07-06  1:48   ` Akihiko Odaki
2023-07-05 11:59 ` [PATCH v8 6/6] hw/pci: add comment explaining the reason for checking function 0 in hotplug Ani Sinha
2023-07-05 12:03   ` Ani Sinha
2023-07-10 19:43     ` Michael S. Tsirkin
2023-07-11  3:46       ` Ani Sinha
2023-07-11  3:51         ` Michael Tokarev
2023-07-11  4:03           ` Ani Sinha
2023-07-11  4:13             ` Michael Tokarev
2023-07-11  4:36               ` Ani Sinha
2023-07-05 11:59 ` [PATCH v8 6/6] hw/pci: add comment to explain checking for available function 0 in pci hotplug Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230705115925.5339-3-anisinha@redhat.com \
    --to=anisinha@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).