From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH v8 14/20] target/riscv/kvm.c: add multi-letter extension KVM properties
Date: Thu, 6 Jul 2023 11:37:48 +0200 [thread overview]
Message-ID: <20230706-38ab9f9705448bb10413f1af@orel> (raw)
In-Reply-To: <20230706-ec06b3d750f813f9c7256fe9@orel>
On Thu, Jul 06, 2023 at 10:45:04AM +0200, Andrew Jones wrote:
...
> 1. Audit KVM to ensure using EINVAL for get-one-reg's "register not
> present" is currently safe, and keep our eye on KVM to make sure
> it remains safe until get-reg-list lands.
I just did the audit and it looks fine. There's only one way these types
of get-one-reg invocations can return EINVAL other than for "register
not present" and that's for the encoded reg size not being
sizeof(unsigned long). As long as we construct the register ID with the
correct size then that can't happen. We currently construct it with
kvm_riscv_reg_id() which does the right thing for these invocations.
Thanks,
drew
next prev parent reply other threads:[~2023-07-06 9:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 21:39 [PATCH v8 00/20] target/riscv, KVM: fixes and enhancements Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 01/20] target/riscv: skip features setup for KVM CPUs Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 02/20] hw/riscv/virt.c: skip 'mmu-type' FDT if satp mode not set Daniel Henrique Barboza
2023-07-05 21:49 ` Conor Dooley
2023-07-05 22:00 ` Daniel Henrique Barboza
2023-07-05 22:12 ` Conor Dooley
2023-07-05 22:18 ` Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 03/20] target/riscv/cpu.c: restrict 'mvendorid' value Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 04/20] target/riscv/cpu.c: restrict 'mimpid' value Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 05/20] target/riscv/cpu.c: restrict 'marchid' value Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 06/20] target/riscv: use KVM scratch CPUs to init KVM properties Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 07/20] target/riscv: read marchid/mimpid in kvm_riscv_init_machine_ids() Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 08/20] target/riscv: handle mvendorid/marchid/mimpid for KVM CPUs Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 09/20] linux-headers: Update to v6.4-rc1 Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 10/20] target/riscv/kvm.c: init 'misa_ext_mask' with scratch CPU Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 11/20] target/riscv/cpu: add misa_ext_info_arr[] Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 12/20] target/riscv: add KVM specific MISA properties Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 13/20] target/riscv/kvm.c: update KVM MISA bits Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 14/20] target/riscv/kvm.c: add multi-letter extension KVM properties Daniel Henrique Barboza
2023-07-06 8:45 ` Andrew Jones
2023-07-06 9:37 ` Andrew Jones [this message]
2023-07-05 21:39 ` [PATCH v8 15/20] target/riscv/cpu.c: add satp_mode properties earlier Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 16/20] target/riscv/cpu.c: remove priv_ver check from riscv_isa_string_ext() Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 17/20] target/riscv/cpu.c: create KVM mock properties Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 18/20] target/riscv: update multi-letter extension KVM properties Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 19/20] target/riscv/kvm.c: add kvmconfig_get_cfg_addr() helper Daniel Henrique Barboza
2023-07-05 21:39 ` [PATCH v8 20/20] target/riscv/kvm.c: read/write (cbom|cboz)_blocksize in KVM Daniel Henrique Barboza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706-38ab9f9705448bb10413f1af@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).