From: Laszlo Ersek <lersek@redhat.com>
To: qemu-devel@nongnu.org, lersek@redhat.com
Cc: Juan Quintela <quintela@redhat.com>,
Leonardo Bras <leobras@redhat.com>, Peter Xu <peterx@redhat.com>,
qemu-trivial@nongnu.org
Subject: [PATCH 2/2] migration: unexport migrate_fd_error()
Date: Thu, 6 Jul 2023 12:29:37 +0200 [thread overview]
Message-ID: <20230706102937.82490-3-lersek@redhat.com> (raw)
In-Reply-To: <20230706102937.82490-1-lersek@redhat.com>
The only migrate_fd_error() call sites are in "migration/migration.c",
which is also where we define migrate_fd_error(). Make the function
static, and remove its declaration from "migration/migration.h".
Cc: Juan Quintela <quintela@redhat.com> (maintainer:Migration)
Cc: Leonardo Bras <leobras@redhat.com> (reviewer:Migration)
Cc: Peter Xu <peterx@redhat.com> (reviewer:Migration)
Cc: qemu-trivial@nongnu.org
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2018404
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
migration/migration.h | 1 -
migration/migration.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/migration/migration.h b/migration/migration.h
index a80b22b703cd..b7c8b67542b8 100644
--- a/migration/migration.h
+++ b/migration/migration.h
@@ -466,7 +466,6 @@ bool migration_has_all_channels(void);
uint64_t migrate_max_downtime(void);
void migrate_set_error(MigrationState *s, const Error *error);
-void migrate_fd_error(MigrationState *s, const Error *error);
void migrate_fd_connect(MigrationState *s, Error *error_in);
diff --git a/migration/migration.c b/migration/migration.c
index a60a5acee533..91bba630a828 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1220,7 +1220,7 @@ static void migrate_error_free(MigrationState *s)
}
}
-void migrate_fd_error(MigrationState *s, const Error *error)
+static void migrate_fd_error(MigrationState *s, const Error *error)
{
trace_migrate_fd_error(error_get_pretty(error));
assert(s->to_dst_file == NULL);
next prev parent reply other threads:[~2023-07-06 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 10:29 [PATCH 0/2] migration: trivialities Laszlo Ersek
2023-07-06 10:29 ` [PATCH 1/2] migration: factor out "resume_requested" in qmp_migrate() Laszlo Ersek
2023-07-06 11:42 ` Juan Quintela
2023-07-06 13:28 ` Michael Tokarev
2023-07-06 14:36 ` Laszlo Ersek
2023-07-06 16:42 ` Philippe Mathieu-Daudé
2023-07-06 10:29 ` Laszlo Ersek [this message]
2023-07-06 11:42 ` [PATCH 2/2] migration: unexport migrate_fd_error() Juan Quintela
2023-07-06 16:44 ` Philippe Mathieu-Daudé
2023-07-06 12:05 ` [PATCH 0/2] migration: trivialities Peter Xu
2023-07-06 17:09 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706102937.82490-3-lersek@redhat.com \
--to=lersek@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).