From: "Richard W.M. Jones" <rjones@redhat.com>
To: richard.henderson@linaro.org
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: [PATCH] tb-maint: Document #ifdef..else..endif correctly
Date: Thu, 6 Jul 2023 14:43:09 +0100 [thread overview]
Message-ID: <20230706134314.907591-1-rjones@redhat.com> (raw)
It was hard to tell from the comments whether the code applied to user
mode (CONFIG_USER_ONLY) or system mode. Fix the comments on the #else
and #endif directives to be clearer.
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
accel/tcg/tb-maint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c
index 9566224d18..bf99a46872 100644
--- a/accel/tcg/tb-maint.c
+++ b/accel/tcg/tb-maint.c
@@ -156,7 +156,7 @@ static PageForEachNext foreach_tb_next(PageForEachNext tb,
return NULL;
}
-#else
+#else /* !CONFIG_USER_ONLY */
/*
* In system mode we want L1_MAP to be based on ram offsets.
*/
@@ -722,7 +722,7 @@ static void page_unlock_tb(const TranslationBlock *tb)
}
}
}
-#endif /* CONFIG_USER_ONLY */
+#endif /* !CONFIG_USER_ONLY */
/* flush all the translation blocks */
static void do_tb_flush(CPUState *cpu, run_on_cpu_data tb_flush_count)
--
2.41.0
next reply other threads:[~2023-07-06 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 13:43 Richard W.M. Jones [this message]
2023-07-06 16:52 ` [PATCH] tb-maint: Document #ifdef..else..endif correctly Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706134314.907591-1-rjones@redhat.com \
--to=rjones@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).