From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Leonardo Bras Soares Passos <leobras@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Juan Quintela <quintela@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/1] pcie: Add hotplug detect state register to cmask
Date: Thu, 6 Jul 2023 14:50:20 -0400 [thread overview]
Message-ID: <20230706144844-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <ZKcEjfTDDgDZWu9Q@x1n>
On Thu, Jul 06, 2023 at 02:14:37PM -0400, Peter Xu wrote:
> On Thu, Jul 06, 2023 at 03:07:40PM -0300, Leonardo Bras Soares Passos wrote:
> > > I asked the same question, and I still keep confused: whether there's a
> > > first bad commit? Starting from when it fails?
> > >
> > > For example, is this broken on 6.0 binaries too with pc-q35-6.0?
> >
> > I tested for qemu 6.0, and it still reproduces, but have not pursued
> > this any further.
>
> I see, thanks!
>
> But then do you know why it's never hit before? I assume it means this bug
> has been there for a long time.
It's a race - you have to migrate after the bit has been set before
the bit got cleared.
cmask is exactly for bits that qemu modifies itself.
--
MST
next prev parent reply other threads:[~2023-07-06 18:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 4:55 [PATCH v2 1/1] pcie: Add hotplug detect state register to cmask Leonardo Bras
2023-07-06 7:37 ` Juan Quintela
2023-07-06 17:58 ` Leonardo Bras Soares Passos
2023-07-06 14:35 ` Peter Xu
2023-07-06 18:07 ` Leonardo Bras Soares Passos
2023-07-06 18:14 ` Peter Xu
2023-07-06 18:37 ` Leonardo Bras Soares Passos
2023-07-06 18:50 ` Michael S. Tsirkin [this message]
2023-07-06 19:02 ` Peter Xu
2023-07-06 20:00 ` Michael S. Tsirkin
2023-07-06 20:17 ` Peter Xu
2023-07-10 17:49 ` Leonardo Bras Soares Passos
2023-07-10 18:16 ` Michael S. Tsirkin
2023-07-10 21:48 ` Leonardo Bras Soares Passos
2023-07-06 21:47 ` Leonardo Bras Soares Passos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706144844-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=leobras@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).