From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: Juan Quintela <quintela@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH 1/2] target/arm: Return negative value on power state migration error
Date: Thu, 6 Jul 2023 16:52:00 -0300 [thread overview]
Message-ID: <20230706195201.18595-2-farosas@suse.de> (raw)
In-Reply-To: <20230706195201.18595-1-farosas@suse.de>
All migration hooks, except this one, return -1 on error and 0 on
success.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
target/arm/machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/arm/machine.c b/target/arm/machine.c
index fc4a4a4064..db3fcd5ae4 100644
--- a/target/arm/machine.c
+++ b/target/arm/machine.c
@@ -702,7 +702,7 @@ static int put_power(QEMUFile *f, void *opaque, size_t size,
qemu_put_byte(f, powered_off);
return 0;
} else {
- return 1;
+ return -1;
}
}
--
2.35.3
next prev parent reply other threads:[~2023-07-06 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 19:51 [PATCH 0/2] migration: Only pass negative values to qemu_file_set_error() Fabiano Rosas
2023-07-06 19:52 ` Fabiano Rosas [this message]
2023-07-06 19:52 ` [PATCH 2/2] migration: Make it clear that qemu_file_set_error() needs a negative value Fabiano Rosas
2023-07-13 11:23 ` Peter Maydell
2023-07-13 13:18 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706195201.18595-2-farosas@suse.de \
--to=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).