From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: "Juan Quintela" <quintela@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Steve Sistare" <steven.sistare@oracle.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PATCH v4 0/6] migration: Test the new "file:" migration
Date: Thu, 6 Jul 2023 17:19:21 -0300 [thread overview]
Message-ID: <20230706201927.15442-1-farosas@suse.de> (raw)
Based-on:
[PATCH V4 0/2] migration file URI
https://lore.kernel.org/r/1688135108-316997-1-git-send-email-steven.sistare@oracle.com
Since v3:
- used FILE_TEST_FILENAME for the three tests
v3:
https://lore.kernel.org/r/20230630212902.19925-1-farosas@suse.de
v2:
https://lore.kernel.org/r/20230628165542.17214-1-farosas@suse.de
v1:
https://lore.kernel.org/r/20230626182210.8792-1-farosas@suse.de
Here's the test for the file: migration.
I hit an issue with the setting of migration status. If we call
query-migrate too soon after migrate-incoming, the query returns an
empty response because we're not setting the MIGRATION_STATUS_SETUP in
the incoming path. We just send the event, but never actually change
state.
Aside from the fix, there's some tidying up to avoid duplicating too
much code in the tests.
Thanks
CI run: https://gitlab.com/farosas/qemu/-/pipelines/912226554
Fabiano Rosas (6):
tests/qtest: migration: Expose migrate_set_capability
tests/qtest: migration: Add migrate_incoming_qmp helper
tests/qtest: migration: Use migrate_incoming_qmp where appropriate
migration: Set migration status early in incoming side
tests/qtest: migration: Add support for negative testing of
qmp_migrate
tests/qtest: migration-test: Add tests for file-based migration
migration/migration.c | 7 +-
tests/qtest/libqtest.c | 33 +++++++
tests/qtest/libqtest.h | 28 ++++++
tests/qtest/meson.build | 1 +
tests/qtest/migration-helpers.c | 60 +++++++++++++
tests/qtest/migration-helpers.h | 10 +++
tests/qtest/migration-test.c | 138 +++++++++++++++++++++++++-----
tests/qtest/virtio-net-failover.c | 77 ++---------------
8 files changed, 261 insertions(+), 93 deletions(-)
--
2.35.3
next reply other threads:[~2023-07-06 20:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 20:19 Fabiano Rosas [this message]
2023-07-06 20:19 ` [PATCH v4 1/6] tests/qtest: migration: Expose migrate_set_capability Fabiano Rosas
2023-07-06 20:19 ` [PATCH v4 2/6] tests/qtest: migration: Add migrate_incoming_qmp helper Fabiano Rosas
2023-07-06 20:19 ` [PATCH v4 3/6] tests/qtest: migration: Use migrate_incoming_qmp where appropriate Fabiano Rosas
2023-07-06 20:19 ` [PATCH v4 4/6] migration: Set migration status early in incoming side Fabiano Rosas
2023-07-06 20:19 ` [PATCH v4 5/6] tests/qtest: migration: Add support for negative testing of qmp_migrate Fabiano Rosas
2023-07-06 20:19 ` [PATCH v4 6/6] tests/qtest: migration-test: Add tests for file-based migration Fabiano Rosas
2023-07-11 22:27 ` Fabiano Rosas
2023-07-12 7:03 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706201927.15442-1-farosas@suse.de \
--to=farosas@suse.de \
--cc=berrange@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=steven.sistare@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).