qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Subject: [PULL 14/21] tests/qtest/readconfig-test: Allow testing for arbitrary memory sizes
Date: Mon, 10 Jul 2023 14:15:36 +0200	[thread overview]
Message-ID: <20230710121543.197250-15-thuth@redhat.com> (raw)
In-Reply-To: <20230710121543.197250-1-thuth@redhat.com>

Make test_x86_memdev_resp() more flexible by allowing arbitrary
memory sizes as parameter here.

Message-Id: <20230704071655.75381-2-thuth@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/qtest/readconfig-test.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/qtest/readconfig-test.c b/tests/qtest/readconfig-test.c
index ac7242451b..74526f3af2 100644
--- a/tests/qtest/readconfig-test.c
+++ b/tests/qtest/readconfig-test.c
@@ -48,7 +48,7 @@ static QTestState *qtest_init_with_config(const char *cfgdata)
     return qts;
 }
 
-static void test_x86_memdev_resp(QObject *res)
+static void test_x86_memdev_resp(QObject *res, const char *mem_id, int size)
 {
     Visitor *v;
     g_autoptr(MemdevList) memdevs = NULL;
@@ -63,8 +63,8 @@ static void test_x86_memdev_resp(QObject *res)
     g_assert(!memdevs->next);
 
     memdev = memdevs->value;
-    g_assert_cmpstr(memdev->id, ==, "ram");
-    g_assert_cmpint(memdev->size, ==, 200 * MiB);
+    g_assert_cmpstr(memdev->id, ==, mem_id);
+    g_assert_cmpint(memdev->size, ==, size * MiB);
 
     visit_free(v);
 }
@@ -80,7 +80,7 @@ static void test_x86_memdev(void)
     qts = qtest_init_with_config(cfgdata);
     /* Test valid command */
     resp = qtest_qmp(qts, "{ 'execute': 'query-memdev' }");
-    test_x86_memdev_resp(qdict_get(resp, "return"));
+    test_x86_memdev_resp(qdict_get(resp, "return"), "ram", 200);
     qobject_unref(resp);
 
     qtest_quit(qts);
-- 
2.39.3



  parent reply	other threads:[~2023-07-10 12:22 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 12:15 [PULL 00/21] s390x, qtest and misc patches before the 8.1 soft freeze Thomas Huth
2023-07-10 12:15 ` [PULL 01/21] hw/s390x: Move KVM specific PV from hw/ to target/s390x/kvm/ Thomas Huth
2023-07-10 12:15 ` [PULL 02/21] linux-user: elfload: Add more initial s390x PSW bits Thomas Huth
2023-07-10 12:15 ` [PULL 03/21] target/s390x: Fix EPSW CC reporting Thomas Huth
2023-07-10 12:15 ` [PULL 04/21] target/s390x: Fix MDEB and MDEBR Thomas Huth
2023-07-10 12:15 ` [PULL 05/21] target/s390x: Fix MVCRL with a large value in R0 Thomas Huth
2023-07-10 12:15 ` [PULL 06/21] target/s390x: Fix LRA overwriting the top 32 bits on DAT error Thomas Huth
2023-07-10 12:15 ` [PULL 07/21] target/s390x: Fix LRA when DAT is off Thomas Huth
2023-07-10 12:15 ` [PULL 08/21] target/s390x: Fix relative long instructions with large offsets Thomas Huth
2023-07-10 12:15 ` [PULL 09/21] tests/tcg/s390x: Test EPSW Thomas Huth
2023-07-10 12:15 ` [PULL 10/21] tests/tcg/s390x: Test LARL with a large offset Thomas Huth
2023-07-10 12:15 ` [PULL 11/21] tests/tcg/s390x: Test LRA Thomas Huth
2023-07-10 12:15 ` [PULL 12/21] tests/tcg/s390x: Test MDEB and MDEBR Thomas Huth
2023-07-10 12:15 ` [PULL 13/21] tests/tcg/s390x: Test MVCRL with a large value in R0 Thomas Huth
2023-07-10 13:09   ` Richard Henderson
2023-07-10 13:13     ` Ilya Leoshkevich
2023-07-10 13:15       ` Thomas Huth
2023-07-10 12:15 ` Thomas Huth [this message]
2023-07-10 12:15 ` [PULL 15/21] tests/qtest: Move mkimg() and have_qemu_img() from libqos to libqtest Thomas Huth
2023-07-10 12:15 ` [PULL 16/21] tests/qtest/readconfig: Test the docs/config/q35-*.cfg files Thomas Huth
2023-07-10 12:15 ` [PULL 17/21] os-posix: Allow 'chroot' via '-run-with' and deprecate the old '-chroot' option Thomas Huth
2023-07-10 12:15 ` [PULL 18/21] meson.build: Skip C++ detection unless we're targeting Windows Thomas Huth
2023-07-10 12:15 ` [PULL 19/21] tests/tcg/s390x: Fix test-svc with clang Thomas Huth
2023-07-10 12:15 ` [PULL 20/21] tests/qtest: massively speed up migration-test Thomas Huth
2023-07-10 12:15 ` [PULL 21/21] docs/devel: Fix coding style in style.rst Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230710121543.197250-15-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).