From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Raphael Norwitz" <raphael.norwitz@nutanix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Kevin Wolf" <kwolf@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Hanna Reitz" <hreitz@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Erik Schilling" <erik.schilling@linaro.org>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Fam Zheng" <fam@euphon.net>,
virtio-fs@redhat.com, "Stefan Hajnoczi" <stefanha@redhat.com>
Subject: [PATCH v3 00/20] virtio: add vhost-user-generic, reduce c&p and support standalone
Date: Mon, 10 Jul 2023 16:35:02 +0100 [thread overview]
Message-ID: <20230710153522.3469097-1-alex.bennee@linaro.org> (raw)
A lot of our vhost-user stubs are large chunks of boilerplate that do
(mostly) the same thing. This series attempts to fix that by defining
a new base class (vhost-user-base) which is used by a generic
vhost-user-device implementation. Then the rng, gpio and i2c
vhost-user devices become simple specialisations of the common base
defining the ID, number of queues and potentially the config handling.
However as of v3 we go a bit further and introduce a new protocol
feature called F_STANDALONE which adds some messages to vhost-user
that allow the daemon to fully advertise its capabilities.
Example
=======
Using the vhost-device-rng built from this branch (draft PR):
https://github.com/rust-vmm/vhost-device/pull/394
You can start QEMU with an even simpler command line:
-chardev socket,id=vus,path=/tmp/vus.sock0 \
-device vhost-user-device-pci,chardev=vus \
-d trace:vhost_\*,trace:vhost_user\*
which doesn't specify any queues or config space but gets it from the
daemon as it starts up. This does involve a bit of shuffling around in
the guts of the vhost code so currently it is RFC status.
Anything for 8.1?
=================
mst,
I don't know if you want to cherry pick anything up to and including:
hw/virtio: derive vhost-user-i2c from vhost-user-base
which is at least a cleanup. However I'm on holiday for the next 3 or
so weeks so it's perfectly ok to leave this as 8.2 material if you
want.
Alex.
Alex Bennée (20):
include: attempt to document device_class_set_props
include/hw: document the device_class_set_parent_* fns
hw/virtio: fix typo in VIRTIO_CONFIG_IRQ_IDX comments
include/hw/virtio: document virtio_notify_config
include/hw/virtio: add kerneldoc for virtio_init
include/hw/virtio: document some more usage of notifiers
virtio: add vhost-user-base and a generic vhost-user-device
virtio: add PCI stub for vhost-user-device
hw/virtio: derive vhost-user-rng from vhost-user-device
hw/virtio: add config support to vhost-user-device
hw/virtio: derive vhost-user-gpio from vhost-user-device
hw/virtio: derive vhost-user-i2c from vhost-user-base
docs/system: add a basic enumeration of vhost-user devices
docs/interop: define STANDALONE protocol feature for vhost-user
hw/virtio: move vhost_user_init earlier
hw/virtio: move virtq initialisation into internal helper
hw/virtio: push down allocation responsibility for vhost_dev->vqs
hw/virtio: validate F_STANDALONE also supports other protocol features
hw/virtio: probe backend for specs if it supports it
hw/virtio: allow vhost-user-device to be driven by backend
docs/interop/vhost-user.rst | 39 +++
docs/system/devices/vhost-user-rng.rst | 2 +
docs/system/devices/vhost-user.rst | 41 +++
include/hw/qdev-core.h | 36 +++
include/hw/virtio/vhost-user-blk.h | 1 -
include/hw/virtio/vhost-user-device.h | 46 +++
include/hw/virtio/vhost-user-gpio.h | 23 +-
include/hw/virtio/vhost-user-i2c.h | 18 +-
include/hw/virtio/vhost-user-rng.h | 11 +-
include/hw/virtio/vhost.h | 21 ++
include/hw/virtio/virtio.h | 21 ++
backends/vhost-user.c | 1 -
hw/block/vhost-user-blk.c | 7 +-
hw/display/vhost-user-gpu.c | 4 +-
hw/net/virtio-net.c | 4 +-
hw/scsi/vhost-scsi.c | 2 -
hw/scsi/vhost-user-scsi.c | 6 -
hw/virtio/vdpa-dev.c | 9 +-
hw/virtio/vhost-user-device-pci.c | 71 +++++
hw/virtio/vhost-user-device.c | 396 ++++++++++++++++++++++++
hw/virtio/vhost-user-fs.c | 5 +-
hw/virtio/vhost-user-gpio.c | 400 ++-----------------------
hw/virtio/vhost-user-i2c.c | 271 +----------------
hw/virtio/vhost-user-rng.c | 277 ++---------------
hw/virtio/vhost-user.c | 84 ++++++
hw/virtio/vhost-vsock-common.c | 4 +-
hw/virtio/vhost.c | 70 +++--
hw/virtio/virtio-crypto.c | 4 +-
hw/virtio/meson.build | 20 +-
29 files changed, 898 insertions(+), 996 deletions(-)
create mode 100644 include/hw/virtio/vhost-user-device.h
create mode 100644 hw/virtio/vhost-user-device-pci.c
create mode 100644 hw/virtio/vhost-user-device.c
--
2.39.2
next reply other threads:[~2023-07-10 15:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 15:35 Alex Bennée [this message]
2023-07-10 15:35 ` [PATCH v3 01/20] include: attempt to document device_class_set_props Alex Bennée
2023-07-10 15:35 ` [PATCH v3 02/20] include/hw: document the device_class_set_parent_* fns Alex Bennée
2023-07-10 15:35 ` [PATCH v3 03/20] hw/virtio: fix typo in VIRTIO_CONFIG_IRQ_IDX comments Alex Bennée
2023-07-10 21:56 ` Philippe Mathieu-Daudé
2023-07-10 15:35 ` [PATCH v3 04/20] include/hw/virtio: document virtio_notify_config Alex Bennée
2023-07-10 15:35 ` [PATCH v3 05/20] include/hw/virtio: add kerneldoc for virtio_init Alex Bennée
2023-07-10 21:58 ` Philippe Mathieu-Daudé
2023-07-10 15:35 ` [PATCH v3 06/20] include/hw/virtio: document some more usage of notifiers Alex Bennée
2023-07-10 15:35 ` [PATCH v3 07/20] virtio: add vhost-user-base and a generic vhost-user-device Alex Bennée
2023-07-10 20:15 ` Michael S. Tsirkin
2023-09-05 14:19 ` Matias Ezequiel Vara Larsen
2023-09-05 17:01 ` Alex Bennée
2023-09-06 9:21 ` Matias Ezequiel Vara Larsen
2023-07-10 15:35 ` [PATCH v3 08/20] virtio: add PCI stub for vhost-user-device Alex Bennée
2023-07-10 15:35 ` [PATCH v3 09/20] hw/virtio: derive vhost-user-rng from vhost-user-device Alex Bennée
2023-07-10 15:35 ` [PATCH v3 10/20] hw/virtio: add config support to vhost-user-device Alex Bennée
2023-07-10 19:58 ` Michael S. Tsirkin
2023-08-31 14:23 ` Albert Esteve
2023-08-31 15:47 ` Alex Bennée
2023-09-01 5:56 ` Erik Schilling
2023-09-01 8:34 ` Albert Esteve
2023-07-10 15:35 ` [PATCH v3 11/20] hw/virtio: derive vhost-user-gpio from vhost-user-device Alex Bennée
2023-07-10 15:35 ` [PATCH v3 12/20] hw/virtio: derive vhost-user-i2c from vhost-user-base Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 13/20] docs/system: add a basic enumeration of vhost-user devices Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 14/20] docs/interop: define STANDALONE protocol feature for vhost-user Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 15/20] hw/virtio: move vhost_user_init earlier Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 16/20] hw/virtio: move virtq initialisation into internal helper Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 17/20] hw/virtio: push down allocation responsibility for vhost_dev->vqs Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 18/20] hw/virtio: validate F_STANDALONE also supports other protocol features Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 19/20] hw/virtio: probe backend for specs if it supports it Alex Bennée
2023-07-10 15:35 ` [RFC PATCH v3 20/20] hw/virtio: allow vhost-user-device to be driven by backend Alex Bennée
2023-09-01 10:00 ` Albert Esteve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230710153522.3469097-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=erik.schilling@linaro.org \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mathieu.poirier@linaro.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=raphael.norwitz@nutanix.com \
--cc=stefanha@redhat.com \
--cc=viresh.kumar@linaro.org \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).