qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] tests/qtest: Fix typo in multifd cancel test
@ 2023-07-11 21:21 Fabiano Rosas
  2023-07-12  8:42 ` Daniel P. Berrangé
  0 siblings, 1 reply; 2+ messages in thread
From: Fabiano Rosas @ 2023-07-11 21:21 UTC (permalink / raw)
  To: qemu-devel
  Cc: Juan Quintela, Daniel P . Berrangé, Peter Xu, Leonardo Bras,
	Thomas Huth, Laurent Vivier, Paolo Bonzini

This wasn't noticed because the test is currently disabled.

Signed-off-by: Fabiano Rosas <farosas@suse.de>
Fixes: 02f56e3de ("tests/qtest: massively speed up migration-test")
---
 tests/qtest/migration-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index efa8c729db..e256da1216 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -2481,7 +2481,7 @@ static void test_multifd_tcp_cancel(void)
 
     migrate_qmp(from, uri, "{}");
 
-    migrate_wait_for_dirty_mem(from, to);
+    migrate_wait_for_dirty_mem(from, to2);
 
     migrate_ensure_converge(from);
 
-- 
2.35.3



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] tests/qtest: Fix typo in multifd cancel test
  2023-07-11 21:21 [PATCH] tests/qtest: Fix typo in multifd cancel test Fabiano Rosas
@ 2023-07-12  8:42 ` Daniel P. Berrangé
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2023-07-12  8:42 UTC (permalink / raw)
  To: Fabiano Rosas
  Cc: qemu-devel, Juan Quintela, Peter Xu, Leonardo Bras, Thomas Huth,
	Laurent Vivier, Paolo Bonzini

On Tue, Jul 11, 2023 at 06:21:31PM -0300, Fabiano Rosas wrote:
> This wasn't noticed because the test is currently disabled.
> 
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
> Fixes: 02f56e3de ("tests/qtest: massively speed up migration-test")
> ---
>  tests/qtest/migration-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index efa8c729db..e256da1216 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -2481,7 +2481,7 @@ static void test_multifd_tcp_cancel(void)
>  
>      migrate_qmp(from, uri, "{}");
>  
> -    migrate_wait_for_dirty_mem(from, to);
> +    migrate_wait_for_dirty_mem(from, to2);
>  
>      migrate_ensure_converge(from);
>  
> -- 
> 2.35.3
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-12  8:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-11 21:21 [PATCH] tests/qtest: Fix typo in multifd cancel test Fabiano Rosas
2023-07-12  8:42 ` Daniel P. Berrangé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).