From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [GIT PULL 02/21] memory-device: Introduce machine_memory_devices_init()
Date: Wed, 12 Jul 2023 10:17:31 +0200 [thread overview]
Message-ID: <20230712081750.80852-3-david@redhat.com> (raw)
In-Reply-To: <20230712081750.80852-1-david@redhat.com>
Let's intrduce a new helper that we will use to replace existing memory
device setup code during machine initialization. We'll enforce that the
size has to be > 0.
Once all machines were converted, we'll only allocate ms->device_memory
if the size > 0.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20230623124553.400585-3-david@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/mem/memory-device.c | 14 ++++++++++++++
include/hw/boards.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/hw/mem/memory-device.c b/hw/mem/memory-device.c
index 49f86ec8a8..bb9d7c2a20 100644
--- a/hw/mem/memory-device.c
+++ b/hw/mem/memory-device.c
@@ -17,6 +17,7 @@
#include "qemu/range.h"
#include "hw/virtio/vhost.h"
#include "sysemu/kvm.h"
+#include "exec/address-spaces.h"
#include "trace.h"
static gint memory_device_addr_sort(gconstpointer a, gconstpointer b)
@@ -328,6 +329,19 @@ uint64_t memory_device_get_region_size(const MemoryDeviceState *md,
return memory_region_size(mr);
}
+void machine_memory_devices_init(MachineState *ms, hwaddr base, uint64_t size)
+{
+ g_assert(size);
+ g_assert(!ms->device_memory);
+ ms->device_memory = g_new0(DeviceMemoryState, 1);
+ ms->device_memory->base = base;
+
+ memory_region_init(&ms->device_memory->mr, OBJECT(ms), "device-memory",
+ size);
+ memory_region_add_subregion(get_system_memory(), ms->device_memory->base,
+ &ms->device_memory->mr);
+}
+
static const TypeInfo memory_device_info = {
.name = TYPE_MEMORY_DEVICE,
.parent = TYPE_INTERFACE,
diff --git a/include/hw/boards.h b/include/hw/boards.h
index 12d9e9d17c..3b7c30e853 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -37,6 +37,7 @@ void machine_parse_smp_config(MachineState *ms,
const SMPConfiguration *config, Error **errp);
unsigned int machine_topo_get_cores_per_socket(const MachineState *ms);
unsigned int machine_topo_get_threads_per_socket(const MachineState *ms);
+void machine_memory_devices_init(MachineState *ms, hwaddr base, uint64_t size);
/**
* machine_class_allow_dynamic_sysbus_dev: Add type to list of valid devices
--
2.41.0
next prev parent reply other threads:[~2023-07-12 8:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 8:17 [GIT PULL 00/21] Host Memory Backends and Memory devices queue 2023-07-12 David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 01/21] memory-device: Unify enabled vs. supported error messages David Hildenbrand
2023-07-12 8:17 ` David Hildenbrand [this message]
2023-07-12 8:17 ` [GIT PULL 03/21] hw/arm/virt: Use machine_memory_devices_init() David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 04/21] hw/ppc/spapr: " David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 05/21] hw/loongarch/virt: " David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 06/21] hw/i386/pc: " David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 07/21] hw/i386/acpi-build: Rely on machine->device_memory when building SRAT David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 08/21] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 09/21] memory-device: Refactor memory_device_pre_plug() David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 10/21] memory-device: Track used region size in DeviceMemoryState David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 11/21] softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE file mapping David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 12/21] virtio-mem: Skip most of virtio_mem_unplug_all() without plugged memory David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 13/21] migration/ram: Expose ramblock_is_ignored() as migrate_ram_is_ignored() David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 14/21] virtio-mem: Support "x-ignore-shared" migration David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 15/21] virtio-md-pci: New parent type for virtio-mem-pci and virtio-pmem-pci David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 16/21] pc: Factor out (un)plug handling of virtio-md-pci devices David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 17/21] arm/virt: Use virtio-md-pci (un)plug functions David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 18/21] virtio-md-pci: Handle unplug of virtio based memory devices David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 19/21] virtio-md-pci: Support unplug requests for compatible devices David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 20/21] virtio-mem: Prepare for device unplug support David Hildenbrand
2023-07-12 8:17 ` [GIT PULL 21/21] virtio-mem-pci: Device " David Hildenbrand
2023-07-12 16:05 ` [GIT PULL 00/21] Host Memory Backends and Memory devices queue 2023-07-12 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712081750.80852-3-david@redhat.com \
--to=david@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).