qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Garzarella <sgarzare@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mike Christie <michael.christie@oracle.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@gmail.com>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Thomas Huth <thuth@redhat.com>,
	Mark Kanda <mark.kanda@oracle.com>, Fam Zheng <fam@euphon.net>,
	Stefano Garzarella <sgarzare@redhat.com>
Subject: [PATCH 0/3] scsi: fix issue with Linux guest and unit attention
Date: Wed, 12 Jul 2023 15:43:49 +0200	[thread overview]
Message-ID: <20230712134352.118655-1-sgarzare@redhat.com> (raw)

This series tries to fix a problem highlighted by the commit 8cc5583abe
("virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug
events").

We initially thought about reverting that commit, but now we have found
a pre-existing issue introduced by commit 1880ad4f4e ("virtio-scsi:
Batched prepare for cmd reqs"). More details in the discussion of the
reverting tentative [1].

Thanks to Thomas for identifying the commit that highlighted the problem
and providing an easy way to reproduce the issue, Stefan for his useful
comments, Mike for the scsi logs, and a big thanks to Paolo for his help
in preparing this series!

Stefano

[1] https://lore.kernel.org/qemu-devel/i3od362o6unuimlqna3aaedliaabauj6g545esg7txidd4s44e@bkx5des6zytx/

Stefano Garzarella (3):
  scsi: fetch unit attention when creating the request
  scsi: cleanup scsi_clear_unit_attention()
  scsi: clear unit attention only for REPORT LUNS commands

 include/hw/scsi/scsi.h |  1 +
 hw/scsi/scsi-bus.c     | 78 ++++++++++++++++++++++--------------------
 2 files changed, 41 insertions(+), 38 deletions(-)

-- 
2.41.0



             reply	other threads:[~2023-07-12 13:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 13:43 Stefano Garzarella [this message]
2023-07-12 13:43 ` [PATCH 1/3] scsi: fetch unit attention when creating the request Stefano Garzarella
2023-07-12 16:38   ` Paolo Bonzini
2023-07-13 11:43     ` Stefano Garzarella
2024-10-09 16:02   ` Michael Galaxy
2024-10-09 16:28     ` Paolo Bonzini
2024-10-09 18:00       ` Michael Galaxy
2024-10-11 19:44         ` Michael Tokarev
2024-10-23 13:39           ` Michael Galaxy
2023-07-12 13:43 ` [PATCH 2/3] scsi: cleanup scsi_clear_unit_attention() Stefano Garzarella
2023-07-12 13:43 ` [PATCH 3/3] scsi: clear unit attention only for REPORT LUNS commands Stefano Garzarella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712134352.118655-1-sgarzare@redhat.com \
    --to=sgarzare@redhat.com \
    --cc=fam@euphon.net \
    --cc=mark.kanda@oracle.com \
    --cc=michael.christie@oracle.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).