qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Joelle van Dyne <j@getutm.app>
To: qemu-devel@nongnu.org
Cc: Joelle van Dyne <j@getutm.app>,
	Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: [PATCH 09/11] tpm_tis_sysbus: fix crash when PPI is enabled
Date: Wed, 12 Jul 2023 20:51:14 -0700	[thread overview]
Message-ID: <20230713035232.48406-10-j@getutm.app> (raw)
In-Reply-To: <20230713035232.48406-1-j@getutm.app>

If 'ppi' property is set, then `tpm_ppi_reset` is called on reset
which SEGFAULTs because `tpmppi->buf` is not allocated.

Signed-off-by: Joelle van Dyne <j@getutm.app>
---
 hw/tpm/tpm_tis_sysbus.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c
index 45e63efd63..1014d5d993 100644
--- a/hw/tpm/tpm_tis_sysbus.c
+++ b/hw/tpm/tpm_tis_sysbus.c
@@ -124,6 +124,10 @@ static void tpm_tis_sysbus_realizefn(DeviceState *dev, Error **errp)
         error_setg(errp, "'tpmdev' property is required");
         return;
     }
+
+    if (s->ppi_enabled) {
+        sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->ppi.ram);
+    }
 }
 
 static void tpm_tis_sysbus_class_init(ObjectClass *klass, void *data)
-- 
2.39.2 (Apple Git-143)



  parent reply	other threads:[~2023-07-13  3:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  3:51 [PATCH 00/11] tpm: introduce TPM CRB SysBus device Joelle van Dyne
2023-07-13  3:51 ` [PATCH 01/11] tpm_crb: refactor common code Joelle van Dyne
2023-07-13 13:22   ` Stefan Berger
2023-07-13  3:51 ` [PATCH 02/11] tpm_crb: CTRL_RSP_ADDR is 64-bits wide Joelle van Dyne
2023-07-13 15:31   ` Stefan Berger
2023-07-13  3:51 ` [PATCH 03/11] tpm_ppi: refactor memory space initialization Joelle van Dyne
2023-07-13 16:00   ` Stefan Berger
2023-07-13  3:51 ` [PATCH 04/11] tpm_crb: use a single read-as-mem/write-as-mmio mapping Joelle van Dyne
2023-07-13 14:17   ` Stefan Berger
2023-07-13 14:50     ` Peter Maydell
2023-07-13 15:28       ` Stefan Berger
2023-07-13 15:34         ` Peter Maydell
2023-07-13 15:46           ` Stefan Berger
2023-07-13 15:55             ` Peter Maydell
2023-07-13 16:53               ` Stefan Berger
2023-07-13 17:07                 ` Peter Maydell
2023-07-13 17:16                   ` Stefan Berger
2023-07-13 17:18                     ` Peter Maydell
2023-07-13 18:43                       ` Stefan Berger
2023-07-14 10:05                         ` Peter Maydell
2023-07-14 11:56                           ` Stefan Berger
2023-07-14 17:38                             ` Joelle van Dyne
2023-07-13  3:51 ` [PATCH 05/11] tpm_crb: use the ISA bus Joelle van Dyne
2023-07-13 18:35   ` Stefan Berger
2023-07-13  3:51 ` [PATCH 06/11] tpm_crb: move ACPI table building to device interface Joelle van Dyne
2023-07-13 16:08   ` Stefan Berger
2023-07-13 18:10     ` Joelle van Dyne
2023-07-13 18:30       ` Stefan Berger
2023-07-13  3:51 ` [PATCH 07/11] hw/arm/virt: add plug handler for TPM on SysBus Joelle van Dyne
2023-07-13 13:13   ` Stefan Berger
2023-07-13 15:31   ` Peter Maydell
2023-07-13 18:07     ` Joelle van Dyne
2023-07-13  3:51 ` [PATCH 08/11] hw/loongarch/virt: " Joelle van Dyne
2023-07-13  3:51 ` Joelle van Dyne [this message]
2023-07-13 16:49   ` [PATCH 09/11] tpm_tis_sysbus: fix crash when PPI is enabled Stefan Berger
2023-07-13 18:15     ` Joelle van Dyne
2023-07-13 18:31       ` Stefan Berger
2023-07-13  3:51 ` [PATCH 10/11] tpm_tis_sysbus: move DSDT AML generation to device Joelle van Dyne
2023-07-13  3:51 ` [PATCH 11/11] tpm_crb_sysbus: introduce TPM CRB SysBus device Joelle van Dyne
2023-07-13 13:07 ` [PATCH 00/11] tpm: " Stefan Berger
2023-07-13 17:35   ` Joelle van Dyne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230713035232.48406-10-j@getutm.app \
    --to=j@getutm.app \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).