qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [PATCH] treewide: spelling fixes in comments and some strings
Date: Fri, 14 Jul 2023 13:40:28 -0600	[thread overview]
Message-ID: <20230714134028.2c987970.alex.williamson@redhat.com> (raw)
In-Reply-To: <849f5b3a-33cd-3406-4462-90ac11bcde96@tls.msk.ru>

On Fri, 14 Jul 2023 21:50:01 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:

> 14.07.2023 21:22, Alex Williamson wrote:
> > On Fri, 14 Jul 2023 14:38:06 +0300
> > Michael Tokarev <mjt@tls.msk.ru> wrote:
> >   
> >> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> >> index d8aeee0b7e..12e7790cf6 100644
> >> --- a/hw/ppc/spapr_pci_vfio.c
> >> +++ b/hw/ppc/spapr_pci_vfio.c
> >> @@ -39,7 +39,7 @@ static void spapr_phb_vfio_eeh_reenable(SpaprPhbState *sphb)
> >>   void spapr_phb_vfio_reset(DeviceState *qdev)
> >>   {
> >>       /*
> >> -     * The PE might be in frozen state. To reenable the EEH
> >> +     * The PE might be in frozen state. To re-enable the EEH
> >>        * functionality on it will clean the frozen state, which
> >>        * ensures that the contained PCI devices will work properly
> >>        * after reboot.  
> > 
> > This looks like personal preference, I can't actually find a source
> > that indicates "reenable" is anything other than a valid alternative of
> > "re-enable".  Thanks,  
> 
> Well, it was one of the questionable suggestions from codespell.  I like
> the re-enable better but in this case I don't really care for one way or
> another. I can drop this and other similar fixes. This one definitely
> does not hurt my eyes when I see it ;)
> 
> $ git diff qemu-master..spelling | grep -c re-enable
> 8
> 
> I can drop those 8 out of 400 :)

If we consider codespell to be the authority I guess we can leave it,
but it seems a bit pedantic to me.  Thanks,

Alex



  reply	other threads:[~2023-07-14 19:41 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 11:38 [PATCH, trivial 00/29] tree-wide spelling fixes in comments and some messages Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 01/29] tree-wide spelling fixes in comments and some messages: block Michael Tokarev
2023-07-14 13:06   ` Michael Tokarev
2023-07-14 11:38 ` [PATCH] treewide: spelling fixes in comments and some strings Michael Tokarev
2023-07-14 11:41   ` Michael Tokarev
2023-07-14 18:22   ` Alex Williamson
2023-07-14 18:50     ` Michael Tokarev
2023-07-14 19:40       ` Alex Williamson [this message]
2023-07-14 19:50         ` Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 02/29] tree-wide spelling fixes in comments and some messages: bsd-user Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 03/29] tree-wide spelling fixes in comments and some messages: ui Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 04/29] tree-wide spelling fixes in comments and some messages: util Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 05/29] tree-wide spelling fixes in comments and some messages: tcg Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 06/29] tree-wide spelling fixes in comments and some messages: docs Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 07/29] tree-wide spelling fixes in comments and some messages: hw/9pfs Michael Tokarev
2023-07-14 12:39   ` Christian Schoenebeck
2023-07-14 11:38 ` [PATCH, trivial 08/29] tree-wide spelling fixes in comments and some messages: arm Michael Tokarev
2023-07-14 12:51   ` Peter Maydell
2023-07-14 11:38 ` [PATCH, trivial 09/29] tree-wide spelling fixes in comments and some messages: i386 Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 10/29] tree-wide spelling fixes in comments and some messages: mips Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 11/29] tree-wide spelling fixes in comments and some messages: ppc Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 12/29] tree-wide spelling fixes in comments and some messages: riscv Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 13/29] tree-wide spelling fixes in comments and some messages: s390x Michael Tokarev
2023-07-14 11:54   ` Thomas Huth
2023-07-14 11:38 ` [PATCH, trivial 14/29] tree-wide spelling fixes in comments and some messages: hexagon Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 15/29] tree-wide spelling fixes in comments and some messages: other architectures Michael Tokarev
2023-07-14 12:49   ` Peter Maydell
2023-07-14 13:14     ` Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 16/29] tree-wide spelling fixes in comments and some messages: hw/net Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 17/29] tree-wide spelling fixes in comments and some messages: hw/pci Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 18/29] tree-wide spelling fixes in comments and some messages: hw/tpm Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 19/29] tree-wide spelling fixes in comments and some messages: hw/usb hw/ide hw/i2c Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 20/29] tree-wide spelling fixes in comments and some messages: hw/display Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 21/29] tree-wide spelling fixes in comments and some messages: xen Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 22/29] tree-wide spelling fixes in comments and some messages: audio Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 23/29] tree-wide spelling fixes in comments and some messages: hw/ Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 24/29] tree-wide spelling fixes in comments and some messages: migration/ Michael Tokarev
2023-07-14 13:05   ` Fabiano Rosas
2023-07-14 13:10     ` Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 25/29] tree-wide spelling fixes in comments and some messages: include/ Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 26/29] tree-wide spelling fixes in comments and some messages: scripts/ Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 27/29] tree-wide spelling fixes in comments and some messages: tests/ Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 28/29] tree-wide spelling fixes in comments and some messages: qga/ Michael Tokarev
2023-07-14 11:38 ` [PATCH, trivial 29/29] tree-wide spelling fixes in comments and some messages: other Michael Tokarev
2023-07-14 12:44 ` [PATCH, trivial 00/29] tree-wide spelling fixes in comments and some messages Peter Maydell
2023-07-14 12:54   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230714134028.2c987970.alex.williamson@redhat.com \
    --to=alex.williamson@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).