From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C208EB64DC for ; Mon, 17 Jul 2023 12:46:19 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qLNbO-0005IS-1S; Mon, 17 Jul 2023 08:45:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLNbJ-0005Gx-Mm for qemu-devel@nongnu.org; Mon, 17 Jul 2023 08:45:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLNb4-0007qx-J5 for qemu-devel@nongnu.org; Mon, 17 Jul 2023 08:45:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689597900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XzLgtVVLHwnmkSSgPouLdLdfVgCpfCTRRRKkOdMq0RQ=; b=SSptDe3J/ZwZR9GLLTOP6qZCUyO5Aq35Xekp+iklM9zhzkIP5zpjoRgT2ZUIzO7TX1nu1Z j9+CcVQEq9zqe+sVs8TW6UAg64yXflcuUzdu0N6sXZxk0XcTxmEzloMcEOMQJX+P9B9GnW TZe6ebcvHJyGnqq6SK8Ct9Idf4pdIas= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-645-uUFZRNGxPAuJTWIupQNYDg-1; Mon, 17 Jul 2023 08:44:58 -0400 X-MC-Unique: uUFZRNGxPAuJTWIupQNYDg-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-51bef8bb689so6748946a12.1 for ; Mon, 17 Jul 2023 05:44:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689597897; x=1692189897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XzLgtVVLHwnmkSSgPouLdLdfVgCpfCTRRRKkOdMq0RQ=; b=Vl48RUnhawnROe8gfICim3rludhISt3wIL5Ng4QloCoU/El9fJrlA7NQapMn+tAbMB 6nCtdSiVZ6n2xdYPeslKJ++Rn0mDoaTZ2jBEi49BZYlsHRVffcw6i67yCvgA1ALoLdz4 7yuuOckNfc0J3oVt5TurFdZj6ap3ScwS1IcnHWE3wx6zAtwqK9g8EW/MuK8djZF4np75 tCIHdGwEsX2S2vRCm2/RZlMEnoZb7ugy8oB0eU5K2MQHHHtVPurUw0LkdNS3wf5v057K M/IJNQAkUBOq5dwkaCWbqHoDzspYlynXwqoomPDFDvUlzLNmIXV1S5oEWoCbXms9vRDD gPuA== X-Gm-Message-State: ABy/qLZngE8nJx97+tNeeMEUVEncXAwb9N8kVjyPsOaHtF3PZxnmGXk7 BbAWK0XXYQ1sTevZsEAVLd/pAxYVFVVt+Q+QGQBgx/IRDazeEr9++oNKqlHsbaUE2M3WlQ2O4o3 rnAPgKSREBKgUs14= X-Received: by 2002:a05:6402:3550:b0:51e:5aac:6bad with SMTP id f16-20020a056402355000b0051e5aac6badmr11822744edd.11.1689597897635; Mon, 17 Jul 2023 05:44:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlFEiOuTeZ0938bQOav2M8TtirR5YaGyyHNUWmH3RjHoizvMT6Lgbq87N9HOmGWIn7Tq7jJ4cg== X-Received: by 2002:a05:6402:3550:b0:51e:5aac:6bad with SMTP id f16-20020a056402355000b0051e5aac6badmr11822730edd.11.1689597897359; Mon, 17 Jul 2023 05:44:57 -0700 (PDT) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id y21-20020aa7d515000000b0051ff2b6139esm6323294edq.5.2023.07.17.05.44.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 05:44:56 -0700 (PDT) Date: Mon, 17 Jul 2023 14:44:55 +0200 From: Igor Mammedov To: Peter Maydell Cc: Marcin Juszkiewicz , Gavin Shan , qemu-arm@nongnu.org, qemu-devel@nongnu.org, pbonzini@redhat.com, eduardo@habkost.net, marcel.apfelbaum@gmail.com, philmd@linaro.org, wangyanan55@huawei.com, shan.gavin@gmail.com Subject: Re: [PATCH 0/3] hw/arm/virt: Use generic CPU invalidation Message-ID: <20230717144455.6f02fde9@imammedo.users.ipa.redhat.com> In-Reply-To: References: <20230713054502.410911-1-gshan@redhat.com> <2d21e89f-c965-e8f1-3705-dfea8367fc7e@linaro.org> <20230714135004.230c05b2@imammedo.users.ipa.redhat.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, 14 Jul 2023 13:56:00 +0100 Peter Maydell wrote: > On Fri, 14 Jul 2023 at 12:50, Igor Mammedov wrote: > > > > On Thu, 13 Jul 2023 12:59:55 +0100 > > Peter Maydell wrote: > > > > > On Thu, 13 Jul 2023 at 12:52, Marcin Juszkiewicz > > > wrote: > > > > > > > > W dniu 13.07.2023 o 13:44, Peter Maydell pisze: > > > > > > > > > I see this isn't a change in this patch, but given that > > > > > what the user specifies is not "cortex-a8-arm-cpu" but > > > > > "cortex-a8", why do we include the "-arm-cpu" suffix in > > > > > the error messages? It's not valid syntax to say > > > > > "-cpu cortex-a8-arm-cpu", so it's a bit misleading... > > > > > > > > Internally those cpu names are "max-{TYPE_ARM_CPU}" and similar for > > > > other architectures. > > > > > > Yes; my question is "why are we not using the user-facing > > > string rather than the internal type name?". > > > > With other targets full CPU type name can also be valid > > user-facing string. Namely we use it with -device/device_add > > interface. Considering we would like to have CPU hotplug > > on ARM as well, we shouldn't not outlaw full type name. > > (QMP/monitor interface also mostly uses full type names) > > You don't seem to be able to use the full type name on > x86-64 either: > > $ ./build/all/qemu-system-x86_64 -cpu pentium-x86_64-cpu > qemu-system-x86_64: unable to find CPU model 'pentium-x86_64-cpu' that's because it also tied into old cpu_model resolving routines, and I haven't added typename lookup the last time I've touched it (it was out of topic change anyway). but some targets do recognize typename, while some do a lot more juggling with cpu_model (alpha/ppc), and yet another class (garbage in => cpu type out). With the last one we could just error, while with alpha/ppc we could dumb it down to typenames only. > and '-cpu help' does not list them with the suffix. both above points are fixable, I can prepare PoC patches for that if there is no opposition to the idea. > > Instead it might be better to consolidate on what has > > been done on making CPU '-device' compatible and > > allow to use full CPU type name with '-cpu' on arm machines. > > > > Then later call suffix-less legacy => deprecate/drop it from > > user-facing side including cleanup of all the infra we've > > invented to keep mapping between cpu_model and typename. > > This seems to me like a worsening of the user interface, > and in practice there is not much likelihood of being > able to deprecate-and-drop the nicer user-facing names, > because they are baked into so many command lines and > scripts. Nice names are subjective point, I suspect in a long run once users switched to using longer names, they won't care much about that either. Also it's arguable if it is worsening UI or not. I see using consolidated typenames across the board (incl. UI) as a positive development. As for scripts/CLI users out there, yes it would be disruptive for a while but one can adapt to new naming (or use a wrapper around QEMU that does suffix adding/model mapping as a crutch). It weren't possible to drop anything before we introduced deprecation process, but with it we can do it. > thanks > -- PMM >