From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: [PATCH for-8.1 v2 0/2] target/mips: Avoid shift by negative number in page_table_walk_refill()
Date: Mon, 17 Jul 2023 23:35:02 +0200 [thread overview]
Message-ID: <20230717213504.24777-1-philmd@linaro.org> (raw)
This is a respin of Peter's patch, but
- pass already-evaluated values to walk_directory() instead
of an assert(),
- check 'ptew > 1' instead of directory/leaf_shift == -1,
- use unsigned type
Since v1: walk_directory() doesn't have to rely on the to sanitize
the input values.
Peter, if you don't see this as an improvement I'll take your original
patch.
Regards,
Phil.
Supersedes: <20230717162940.814078-1-peter.maydell@linaro.org>
Philippe Mathieu-Daudé (2):
target/mips: Pass directory/leaf shift values to walk_directory()
target/mips: Avoid shift by negative number in
page_table_walk_refill()
target/mips/tcg/sysemu/tlb_helper.c | 48 ++++++++++++++---------------
1 file changed, 24 insertions(+), 24 deletions(-)
--
2.38.1
next reply other threads:[~2023-07-17 21:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 21:35 Philippe Mathieu-Daudé [this message]
2023-07-17 21:35 ` [PATCH for-8.1 v2 1/2] target/mips: Pass directory/leaf shift values to walk_directory() Philippe Mathieu-Daudé
2023-07-18 10:20 ` Peter Maydell
2023-07-17 21:35 ` [PATCH for-8.1 v2 2/2] target/mips: Avoid shift by negative number in page_table_walk_refill() Philippe Mathieu-Daudé
2023-07-18 5:59 ` Philippe Mathieu-Daudé
2023-07-18 10:25 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717213504.24777-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=jiaxun.yang@flygoat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).