qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, den@virtuozzo.com, stefanha@redhat.com,
	vsementsov@yandex-team.ru, kwolf@redhat.com, hreitz@redhat.com
Subject: [PATCH v8 03/10] parallels: Check if data_end greater than the file size
Date: Tue, 18 Jul 2023 12:44:25 +0200	[thread overview]
Message-ID: <20230718104432.1130469-4-alexander.ivanov@virtuozzo.com> (raw)
In-Reply-To: <20230718104432.1130469-1-alexander.ivanov@virtuozzo.com>

Initially data_end is set to the data_off image header field and must not
be greater than the file size.

Signed-off-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
Reviewed-by: Denis V. Lunev <den@openvz.org>
---
 block/parallels.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/block/parallels.c b/block/parallels.c
index 3c0dca3dbf..6a3d41373a 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -874,6 +874,11 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
          */
         s->header_size = size;
     }
+    if (s->data_end > file_nb_sectors) {
+        error_setg(errp, "Invalid image: incorrect data_off field");
+        ret = -EINVAL;
+        goto fail;
+    }
 
     ret = bdrv_pread(bs->file, 0, s->header_size, s->header, 0);
     if (ret < 0) {
-- 
2.34.1



  parent reply	other threads:[~2023-07-18 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-18 10:44 [PATCH v8 00/10] parallels: Add duplication check, repair at open, fix bugs Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 01/10] parallels: Fix comments formatting inside parallels driver Alexander Ivanov
2023-07-26  9:41   ` Denis V. Lunev
2023-07-18 10:44 ` [PATCH v8 02/10] parallels: Incorrect data end calculation in parallels_open() Alexander Ivanov
2023-07-18 10:44 ` Alexander Ivanov [this message]
2023-07-18 10:44 ` [PATCH v8 04/10] parallels: Add "explicit" argument to parallels_check_leak() Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 05/10] parallels: Add data_start field to BDRVParallelsState Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 06/10] parallels: Add checking and repairing duplicate offsets in BAT Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 07/10] parallels: Image repairing in parallels_open() Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 08/10] parallels: Use bdrv_co_getlength() in parallels_check_outside_image() Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 09/10] parallels: Add data_off check Alexander Ivanov
2023-07-18 10:44 ` [PATCH v8 10/10] parallels: Add data_off repairing to parallels_open() Alexander Ivanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230718104432.1130469-4-alexander.ivanov@virtuozzo.com \
    --to=alexander.ivanov@virtuozzo.com \
    --cc=den@virtuozzo.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).