From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-stable@nongnu.org
Subject: [PATCH 02/14] target/s390x: Fix CLM with M3=0
Date: Tue, 18 Jul 2023 23:21:03 +0200 [thread overview]
Message-ID: <20230718213531.117976-3-iii@linux.ibm.com> (raw)
In-Reply-To: <20230718213531.117976-1-iii@linux.ibm.com>
When the mask is zero, access exceptions should still be recognized for
1 byte at the second-operand address. CC should be set to 0.
Cc: qemu-stable@nongnu.org
Fixes: defb0e3157af ("s390x: Implement opcode helpers")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/mem_helper.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
index f417fb1183c..d6dc8b32620 100644
--- a/target/s390x/tcg/mem_helper.c
+++ b/target/s390x/tcg/mem_helper.c
@@ -667,6 +667,11 @@ uint32_t HELPER(clm)(CPUS390XState *env, uint32_t r1, uint32_t mask,
HELPER_LOG("%s: r1 0x%x mask 0x%x addr 0x%" PRIx64 "\n", __func__, r1,
mask, addr);
+ if (!mask) {
+ /* Recognize access exceptions for the first byte */
+ cpu_ldub_data_ra(env, addr, ra);
+ }
+
while (mask) {
if (mask & 8) {
uint8_t d = cpu_ldub_data_ra(env, addr, ra);
--
2.41.0
next prev parent reply other threads:[~2023-07-18 21:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 21:21 [PATCH 00/14] target/s390x: Miscellaneous TCG fixes, part 2 Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 01/14] target/s390x: Make CKSM raise an exception if R2 is odd Ilya Leoshkevich
2023-07-19 8:26 ` David Hildenbrand
2023-07-18 21:21 ` Ilya Leoshkevich [this message]
2023-07-19 8:27 ` [PATCH 02/14] target/s390x: Fix CLM with M3=0 David Hildenbrand
2023-07-18 21:21 ` [PATCH 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs Ilya Leoshkevich
2023-07-19 8:28 ` David Hildenbrand
2023-07-18 21:21 ` [PATCH 04/14] target/s390x: Fix ICM with M3=0 Ilya Leoshkevich
2023-07-19 8:32 ` David Hildenbrand
2023-07-18 21:21 ` [PATCH 05/14] target/s390x: Make MC raise specification exception when class >= 16 Ilya Leoshkevich
2023-07-19 8:43 ` David Hildenbrand
2023-07-18 21:21 ` [PATCH 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with reserved type Ilya Leoshkevich
2023-07-19 8:40 ` David Hildenbrand
2023-07-19 9:34 ` Ilya Leoshkevich
2023-07-19 9:44 ` David Hildenbrand
2023-07-18 21:21 ` [PATCH 08/14] tests/tcg/s390x: Test CKSM Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 09/14] tests/tcg/s390x: Test CLGEBR and CGEBRA Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 10/14] tests/tcg/s390x: Test CLM Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 11/14] tests/tcg/s390x: Test ICM Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 12/14] tests/tcg/s390x: Test MC Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 13/14] tests/tcg/s390x: Test STPQ Ilya Leoshkevich
2023-07-18 21:21 ` [PATCH 14/14] tests/tcg/s390x: Test VCKSM Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718213531.117976-3-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).