From: Ilya Leoshkevich <iii@linux.ibm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-stable@nongnu.org
Subject: [PATCH v3 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13
Date: Thu, 20 Jul 2023 00:11:19 +0200 [thread overview]
Message-ID: <20230719221310.1968845-8-iii@linux.ibm.com> (raw)
In-Reply-To: <20230719221310.1968845-1-iii@linux.ibm.com>
Type 13 is reserved, so using it should result in specification
exception. Due to an off-by-1 error the code triggers an assertion at a
later point in time instead.
Cc: qemu-stable@nongnu.org
Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)")
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/translate_vx.c.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/s390x/tcg/translate_vx.c.inc b/target/s390x/tcg/translate_vx.c.inc
index 43dfbfd03f6..f8df121d3d3 100644
--- a/target/s390x/tcg/translate_vx.c.inc
+++ b/target/s390x/tcg/translate_vx.c.inc
@@ -3047,7 +3047,7 @@ static DisasJumpType op_vfmax(DisasContext *s, DisasOps *o)
const uint8_t m5 = get_field(s, m5);
gen_helper_gvec_3_ptr *fn;
- if (m6 == 5 || m6 == 6 || m6 == 7 || m6 > 13) {
+ if (m6 == 5 || m6 == 6 || m6 == 7 || m6 >= 13) {
gen_program_exception(s, PGM_SPECIFICATION);
return DISAS_NORETURN;
}
--
2.41.0
next prev parent reply other threads:[~2023-07-19 22:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 22:11 [PATCH v3 00/14] target/s390x: Miscellaneous TCG fixes, part 2 Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 01/14] target/s390x: Make CKSM raise an exception if R2 is odd Ilya Leoshkevich
2023-07-23 16:14 ` Richard Henderson
2023-07-19 22:11 ` [PATCH v3 02/14] target/s390x: Fix CLM with M3=0 Ilya Leoshkevich
2023-07-23 16:22 ` Richard Henderson
2023-07-19 22:11 ` [PATCH v3 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs Ilya Leoshkevich
2023-07-23 16:28 ` Richard Henderson
2023-07-19 22:11 ` [PATCH v3 04/14] target/s390x: Fix ICM with M3=0 Ilya Leoshkevich
2023-07-23 16:30 ` Richard Henderson
2023-07-19 22:11 ` [PATCH v3 05/14] target/s390x: Make MC raise specification exception when class >= 16 Ilya Leoshkevich
2023-07-23 16:33 ` Richard Henderson
2023-07-19 22:11 ` [PATCH v3 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output Ilya Leoshkevich
2023-07-23 16:37 ` [PATCH v3 06/14] tcg/{i386,s390x}: " Richard Henderson
2023-07-19 22:11 ` Ilya Leoshkevich [this message]
2023-07-23 16:40 ` [PATCH v3 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13 Richard Henderson
2023-07-19 22:11 ` [PATCH v3 08/14] tests/tcg/s390x: Test CKSM Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 09/14] tests/tcg/s390x: Test CLGEBR and CGEBRA Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 10/14] tests/tcg/s390x: Test CLM Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 11/14] tests/tcg/s390x: Test ICM Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 12/14] tests/tcg/s390x: Test MC Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 13/14] tests/tcg/s390x: Test STPQ Ilya Leoshkevich
2023-07-19 22:11 ` [PATCH v3 14/14] tests/tcg/s390x: Test VCKSM Ilya Leoshkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719221310.1968845-8-iii@linux.ibm.com \
--to=iii@linux.ibm.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).