From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>,
qemu-block@nongnu.org, Beraldo Leal <bleal@redhat.com>,
Hanna Reitz <hreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Daniel Berrange <berrange@redhat.com>,
Cleber Rosa <crosa@redhat.com>
Subject: [PATCH 0/4] python/machine: use socketpair() for console socket
Date: Thu, 20 Jul 2023 09:04:44 -0400 [thread overview]
Message-ID: <20230720130448.921356-1-jsnow@redhat.com> (raw)
Like we did for the QMP socket, use socketpair() for the console socket
so that hopefully there isn't a race condition during early boot where
data might get dropped on the floor.
"lightly tested"; passes local tests and gitlab CI. Doesn't seem to make
anything worse.
John Snow (4):
python/machine: move socket setup out of _base_args property
python/console_socket: accept existing FD in initializer
python/machine: use socketpair() for console connections
python/machine: remove unused console socket configuration arguments
python/qemu/machine/console_socket.py | 11 +++---
python/qemu/machine/machine.py | 40 +++++++++-------------
python/qemu/machine/qtest.py | 6 ++--
tests/qemu-iotests/tests/copy-before-write | 3 +-
4 files changed, 27 insertions(+), 33 deletions(-)
--
2.41.0
next reply other threads:[~2023-07-20 13:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 13:04 John Snow [this message]
2023-07-20 13:04 ` [PATCH 1/4] python/machine: move socket setup out of _base_args property John Snow
2023-07-20 13:55 ` Daniel P. Berrangé
2023-07-20 13:04 ` [PATCH 2/4] python/console_socket: accept existing FD in initializer John Snow
2023-07-20 14:01 ` Daniel P. Berrangé
2023-07-20 14:35 ` John Snow
2023-07-20 13:04 ` [PATCH 3/4] python/machine: use socketpair() for console connections John Snow
2023-07-20 14:02 ` Daniel P. Berrangé
2023-07-20 13:04 ` [PATCH 4/4] python/machine: remove unused console socket configuration arguments John Snow
2023-07-20 14:04 ` Daniel P. Berrangé
2023-07-20 14:29 ` John Snow
2023-07-20 13:45 ` [PATCH 0/4] python/machine: use socketpair() for console socket Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230720130448.921356-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).