From: Gavin Shan <gshan@redhat.com>
To: qemu-arm@nongnu.org
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
peter.maydell@linaro.org, b.galvani@gmail.com,
strahinja.p.jankovic@gmail.com, sundeep.lkml@gmail.com,
kfting@nuvoton.com, wuhaotsh@google.com,
nieklinnenbank@gmail.com, rad@semihalf.com,
quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org,
eduardo@habkost.net, marcel.apfelbaum@gmail.com,
philmd@linaro.org, wangyanan55@huawei.com, laurent@vivier.eu,
vijai@behindbytes.com, palmer@dabbelt.com,
alistair.francis@wdc.com, bin.meng@windriver.com,
liweiwei@iscas.ac.cn, dbarboza@ventanamicro.com,
zhiwei_liu@linux.alibaba.com, imammedo@redhat.com,
cohuck@redhat.com, richard.henderson@linaro.org,
pbonzini@redhat.com, shan.gavin@gmail.com
Subject: [PATCH v2 0/8] machine: Unified CPU type check
Date: Wed, 26 Jul 2023 10:31:57 +1000 [thread overview]
Message-ID: <20230726003205.1599788-1-gshan@redhat.com> (raw)
There are two places where the user specified CPU type is checked to see
if it's supported or allowed by the board: machine_run_board_init() and
mc->init(). We don't have to maintain two duplicate sets of logic. This
series intends to move the check to machine_run_board_init().
PATCH[1-3] Improves the check in machine_run_board_init()
PATCH[4-8] Move the check mc->init() to machine_run_board_init()
v1: https://lists.nongnu.org/archive/html/qemu-arm/2023-07/msg00302.html
Testing
=======
With the following command lines, the output messages are varied before
and after the series is applied.
/home/gshan/sandbox/src/qemu/main/build/qemu-system-aarch64 \
-accel tcg -machine virt,gic-version=3,nvdimm=on \
-cpu cortex-a8 -smp maxcpus=2,cpus=1 \
:
Before the series is applied:
qemu-system-aarch64: mach-virt: CPU type cortex-a8-arm-cpu not supported
After the series is applied:
qemu-system-aarch64: Invalid CPU type: cortex-a8-arm-cpu
The valid models are: cortex-a7, cortex-a15, cortex-a35, cortex-a55,
cortex-a72, cortex-a76, a64fx, neoverse-n1,
neoverse-v1, cortex-a53, cortex-a57, max
Changelog
=========
v2:
* Constify mc->valid_cpu_types (Richard)
* Print the supported CPU models, instead of typenames (Peter)
* Misc improvements for the hleper to do the check (Igor)
* More patches to move the check (Marcin)
Gavin Shan (8):
machine: Use error handling when CPU type is checked
machine: Introduce helper is_cpu_type_supported()
machine: Print supported CPU models instead of typenames
hw/arm/virt: Check CPU type in machine_run_board_init()
hw/arm/virt: Unsupported host CPU model on TCG
hw/arm/sbsa-ref: Check CPU type in machine_run_board_init()
hw/arm: Check CPU type in machine_run_board_init()
hw/riscv/shakti_c: Check CPU type in machine_run_board_init()
hw/arm/bananapi_m2u.c | 18 ++++++---
hw/arm/cubieboard.c | 18 ++++++---
hw/arm/mps2-tz.c | 34 ++++++++++++++---
hw/arm/mps2.c | 44 ++++++++++++++++++---
hw/arm/msf2-som.c | 18 ++++++---
hw/arm/musca.c | 19 ++++++----
hw/arm/npcm7xx_boards.c | 19 ++++++----
hw/arm/orangepi.c | 18 ++++++---
hw/arm/sbsa-ref.c | 29 ++++++--------
hw/arm/virt.c | 43 ++++++++++++---------
hw/core/machine.c | 84 +++++++++++++++++++++++------------------
hw/m68k/q800.c | 8 +++-
hw/riscv/shakti_c.c | 17 ++++++---
include/hw/boards.h | 3 +-
14 files changed, 243 insertions(+), 129 deletions(-)
--
2.41.0
next reply other threads:[~2023-07-26 0:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 0:31 Gavin Shan [this message]
2023-07-26 0:31 ` [PATCH v2 1/8] machine: Use error handling when CPU type is checked Gavin Shan
2023-07-26 0:31 ` [PATCH v2 2/8] machine: Introduce helper is_cpu_type_supported() Gavin Shan
2023-07-26 23:03 ` Richard Henderson
2023-07-26 0:32 ` [PATCH v2 3/8] machine: Print supported CPU models instead of typenames Gavin Shan
2023-07-26 23:08 ` Richard Henderson
2023-07-27 5:16 ` Gavin Shan
2023-07-27 9:00 ` Igor Mammedov
2023-07-31 5:07 ` Gavin Shan
2023-08-28 14:46 ` Igor Mammedov
2023-08-29 6:28 ` Gavin Shan
2023-08-29 9:03 ` Igor Mammedov
2023-08-30 7:34 ` Gavin Shan
2023-08-31 9:02 ` Igor Mammedov
2023-07-27 14:27 ` Richard Henderson
2023-07-31 5:33 ` Gavin Shan
2023-07-26 0:32 ` [PATCH v2 4/8] hw/arm/virt: Check CPU type in machine_run_board_init() Gavin Shan
2023-07-26 0:32 ` [PATCH v2 5/8] hw/arm/virt: Unsupported host CPU model on TCG Gavin Shan
2023-07-26 0:32 ` [PATCH v2 6/8] hw/arm/sbsa-ref: Check CPU type in machine_run_board_init() Gavin Shan
2023-07-26 0:32 ` [PATCH v2 7/8] hw/arm: " Gavin Shan
2023-07-26 0:32 ` [PATCH v2 8/8] hw/riscv/shakti_c: " Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726003205.1599788-1-gshan@redhat.com \
--to=gshan@redhat.com \
--cc=alistair.francis@wdc.com \
--cc=b.galvani@gmail.com \
--cc=bin.meng@windriver.com \
--cc=cohuck@redhat.com \
--cc=dbarboza@ventanamicro.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=kfting@nuvoton.com \
--cc=laurent@vivier.eu \
--cc=liweiwei@iscas.ac.cn \
--cc=marcel.apfelbaum@gmail.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=nieklinnenbank@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=richard.henderson@linaro.org \
--cc=shan.gavin@gmail.com \
--cc=strahinja.p.jankovic@gmail.com \
--cc=sundeep.lkml@gmail.com \
--cc=vijai@behindbytes.com \
--cc=wangyanan55@huawei.com \
--cc=wuhaotsh@google.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).