From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: Leonardo Bras <leobras@redhat.com>,
Eric Blake <eblake@redhat.com>, Peter Xu <peterx@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Huth <thuth@redhat.com>,
libvir-list@redhat.com, Markus Armbruster <armbru@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Laurent Vivier <lvivier@redhat.com>
Subject: [PULL 12/25] migration-test: Make machine_opts regular with other options
Date: Wed, 26 Jul 2023 14:14:46 +0200 [thread overview]
Message-ID: <20230726121459.1837-13-quintela@redhat.com> (raw)
In-Reply-To: <20230726121459.1837-1-quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230608224943.3877-5-quintela@redhat.com>
---
tests/qtest/migration-test.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 2296ed4bf5..f51a25e299 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -739,7 +739,7 @@ static int test_migrate_start(QTestState **from, QTestState **to,
start_address = S390_TEST_MEM_START;
end_address = S390_TEST_MEM_END;
} else if (strcmp(arch, "ppc64") == 0) {
- machine_opts = "vsmt=8";
+ machine_opts = "-machine vsmt=8";
memory_size = "256M";
start_address = PPC_TEST_MEM_START;
end_address = PPC_TEST_MEM_END;
@@ -751,7 +751,7 @@ static int test_migrate_start(QTestState **from, QTestState **to,
arch_target = g_strdup("-nodefaults");
} else if (strcmp(arch, "aarch64") == 0) {
init_bootfile(bootpath, aarch64_kernel, sizeof(aarch64_kernel));
- machine_opts = "virt,gic-version=max";
+ machine_opts = "-machine virt,gic-version=max";
memory_size = "150M";
arch_source = g_strdup_printf("-cpu max "
"-kernel %s",
@@ -791,14 +791,13 @@ static int test_migrate_start(QTestState **from, QTestState **to,
shmem_opts = g_strdup("");
}
- cmd_source = g_strdup_printf("-accel kvm%s -accel tcg%s%s "
+ cmd_source = g_strdup_printf("-accel kvm%s -accel tcg %s "
"-name source,debug-threads=on "
"-m %s "
"-serial file:%s/src_serial "
"%s %s %s %s",
args->use_dirty_ring ?
",dirty-ring-size=4096" : "",
- machine_opts ? " -machine " : "",
machine_opts ? machine_opts : "",
memory_size, tmpfs,
arch_source, shmem_opts,
@@ -811,7 +810,7 @@ static int test_migrate_start(QTestState **from, QTestState **to,
&got_src_stop);
}
- cmd_target = g_strdup_printf("-accel kvm%s -accel tcg%s%s "
+ cmd_target = g_strdup_printf("-accel kvm%s -accel tcg %s "
"-name target,debug-threads=on "
"-m %s "
"-serial file:%s/dest_serial "
@@ -819,7 +818,6 @@ static int test_migrate_start(QTestState **from, QTestState **to,
"%s %s %s %s",
args->use_dirty_ring ?
",dirty-ring-size=4096" : "",
- machine_opts ? " -machine " : "",
machine_opts ? machine_opts : "",
memory_size, tmpfs, uri,
arch_target, shmem_opts,
--
2.40.1
next prev parent reply other threads:[~2023-07-26 12:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 12:14 [PULL 00/25] Migration 20230726 patches Juan Quintela
2023-07-26 12:14 ` [PULL 01/25] migration/multifd: Rename threadinfo.c functions Juan Quintela
2023-07-26 12:14 ` [PULL 02/25] migration/multifd: Protect accesses to migration_threads Juan Quintela
2023-07-26 12:14 ` [PULL 03/25] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" Juan Quintela
2023-07-26 12:14 ` [PULL 04/25] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter Juan Quintela
2023-07-26 12:14 ` [PULL 05/25] qapi/migration: Introduce vcpu-dirty-limit parameters Juan Quintela
2023-07-26 12:14 ` [PULL 06/25] migration: Introduce dirty-limit capability Juan Quintela
2023-07-26 12:14 ` [PULL 07/25] migration: Refactor auto-converge capability logic Juan Quintela
2023-07-26 12:14 ` [PULL 08/25] migration: Put the detection logic before auto-converge checking Juan Quintela
2023-07-26 12:14 ` [PULL 09/25] migration: Implement dirty-limit convergence algo Juan Quintela
2023-07-26 12:14 ` [PULL 10/25] migration: Extend query-migrate to provide dirty page limit info Juan Quintela
2023-07-26 12:14 ` [PULL 11/25] migration-test: Be consistent for ppc Juan Quintela
2023-07-26 12:14 ` Juan Quintela [this message]
2023-07-26 12:14 ` [PULL 13/25] migration-test: Create arch_opts Juan Quintela
2023-07-26 12:14 ` [PULL 14/25] migration-test: machine_opts is really arch specific Juan Quintela
2023-07-26 12:14 ` [PULL 15/25] migration: skipped field is really obsolete Juan Quintela
2023-07-26 12:14 ` [PULL 16/25] docs/migration: Update postcopy bits Juan Quintela
2023-07-26 12:14 ` [PULL 17/25] migration: Update error description whenever migration fails Juan Quintela
2023-07-26 12:14 ` [PULL 18/25] migration: enforce multifd and postcopy preempt to be set before incoming Juan Quintela
2023-07-26 12:14 ` [PULL 19/25] qtest/migration-tests.c: use "-incoming defer" for postcopy tests Juan Quintela
2023-07-26 12:14 ` [PULL 20/25] qemu-file: Rename qemu_file_transferred_ fast -> noflush Juan Quintela
2023-07-26 12:14 ` [PULL 21/25] migration: Change qemu_file_transferred to noflush Juan Quintela
2023-07-26 12:14 ` [PULL 22/25] qemu_file: Make qemu_file_is_writable() static Juan Quintela
2023-07-26 12:14 ` [PULL 23/25] qemu-file: Simplify qemu_file_shutdown() Juan Quintela
2023-07-26 12:14 ` [PULL 24/25] qemu-file: Make qemu_file_get_error_obj() static Juan Quintela
2023-07-26 12:14 ` [PULL 25/25] migration/rdma: Split qemu_fopen_rdma() into input/output functions Juan Quintela
2023-07-26 16:23 ` [PULL 00/25] Migration 20230726 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726121459.1837-13-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=leobras@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).