From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Leonardo Bras" <leobras@redhat.com>,
"Eric Blake" <eblake@redhat.com>, "Peter Xu" <peterx@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
libvir-list@redhat.com, "Markus Armbruster" <armbru@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 20/25] qemu-file: Rename qemu_file_transferred_ fast -> noflush
Date: Wed, 26 Jul 2023 14:14:54 +0200 [thread overview]
Message-ID: <20230726121459.1837-21-quintela@redhat.com> (raw)
In-Reply-To: <20230726121459.1837-1-quintela@redhat.com>
Fast don't say much. Noflush indicates more clearly that it is like
qemu_file_transferred but without the flush.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230530183941.7223-2-quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/qemu-file.h | 11 +++++------
migration/qemu-file.c | 2 +-
migration/savevm.c | 4 ++--
migration/vmstate.c | 4 ++--
4 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/migration/qemu-file.h b/migration/qemu-file.h
index e649718492..aa6eee66da 100644
--- a/migration/qemu-file.h
+++ b/migration/qemu-file.h
@@ -86,16 +86,15 @@ int qemu_fclose(QEMUFile *f);
uint64_t qemu_file_transferred(QEMUFile *f);
/*
- * qemu_file_transferred_fast:
+ * qemu_file_transferred_noflush:
*
- * As qemu_file_transferred except for writable
- * files, where no flush is performed and the reported
- * amount will include the size of any queued buffers,
- * on top of the amount actually transferred.
+ * As qemu_file_transferred except for writable files, where no flush
+ * is performed and the reported amount will include the size of any
+ * queued buffers, on top of the amount actually transferred.
*
* Returns: the total bytes transferred and queued
*/
-uint64_t qemu_file_transferred_fast(QEMUFile *f);
+uint64_t qemu_file_transferred_noflush(QEMUFile *f);
/*
* put_buffer without copying the buffer.
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index acc282654a..fdf115b5da 100644
--- a/migration/qemu-file.c
+++ b/migration/qemu-file.c
@@ -694,7 +694,7 @@ int coroutine_mixed_fn qemu_get_byte(QEMUFile *f)
return result;
}
-uint64_t qemu_file_transferred_fast(QEMUFile *f)
+uint64_t qemu_file_transferred_noflush(QEMUFile *f)
{
uint64_t ret = f->total_transferred;
int i;
diff --git a/migration/savevm.c b/migration/savevm.c
index 51e40e3a0b..0b2583a205 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -927,9 +927,9 @@ static int vmstate_load(QEMUFile *f, SaveStateEntry *se)
static void vmstate_save_old_style(QEMUFile *f, SaveStateEntry *se,
JSONWriter *vmdesc)
{
- uint64_t old_offset = qemu_file_transferred_fast(f);
+ uint64_t old_offset = qemu_file_transferred_noflush(f);
se->ops->save_state(f, se->opaque);
- uint64_t size = qemu_file_transferred_fast(f) - old_offset;
+ uint64_t size = qemu_file_transferred_noflush(f) - old_offset;
if (vmdesc) {
json_writer_int64(vmdesc, "size", size);
diff --git a/migration/vmstate.c b/migration/vmstate.c
index af01d54b6f..31842c3afb 100644
--- a/migration/vmstate.c
+++ b/migration/vmstate.c
@@ -361,7 +361,7 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
void *curr_elem = first_elem + size * i;
vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems);
- old_offset = qemu_file_transferred_fast(f);
+ old_offset = qemu_file_transferred_noflush(f);
if (field->flags & VMS_ARRAY_OF_POINTER) {
assert(curr_elem);
curr_elem = *(void **)curr_elem;
@@ -391,7 +391,7 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDescription *vmsd,
return ret;
}
- written_bytes = qemu_file_transferred_fast(f) - old_offset;
+ written_bytes = qemu_file_transferred_noflush(f) - old_offset;
vmsd_desc_field_end(vmsd, vmdesc_loop, field, written_bytes, i);
/* Compressed arrays only care about the first element */
--
2.40.1
next prev parent reply other threads:[~2023-07-26 12:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 12:14 [PULL 00/25] Migration 20230726 patches Juan Quintela
2023-07-26 12:14 ` [PULL 01/25] migration/multifd: Rename threadinfo.c functions Juan Quintela
2023-07-26 12:14 ` [PULL 02/25] migration/multifd: Protect accesses to migration_threads Juan Quintela
2023-07-26 12:14 ` [PULL 03/25] softmmu/dirtylimit: Add parameter check for hmp "set_vcpu_dirty_limit" Juan Quintela
2023-07-26 12:14 ` [PULL 04/25] qapi/migration: Introduce x-vcpu-dirty-limit-period parameter Juan Quintela
2023-07-26 12:14 ` [PULL 05/25] qapi/migration: Introduce vcpu-dirty-limit parameters Juan Quintela
2023-07-26 12:14 ` [PULL 06/25] migration: Introduce dirty-limit capability Juan Quintela
2023-07-26 12:14 ` [PULL 07/25] migration: Refactor auto-converge capability logic Juan Quintela
2023-07-26 12:14 ` [PULL 08/25] migration: Put the detection logic before auto-converge checking Juan Quintela
2023-07-26 12:14 ` [PULL 09/25] migration: Implement dirty-limit convergence algo Juan Quintela
2023-07-26 12:14 ` [PULL 10/25] migration: Extend query-migrate to provide dirty page limit info Juan Quintela
2023-07-26 12:14 ` [PULL 11/25] migration-test: Be consistent for ppc Juan Quintela
2023-07-26 12:14 ` [PULL 12/25] migration-test: Make machine_opts regular with other options Juan Quintela
2023-07-26 12:14 ` [PULL 13/25] migration-test: Create arch_opts Juan Quintela
2023-07-26 12:14 ` [PULL 14/25] migration-test: machine_opts is really arch specific Juan Quintela
2023-07-26 12:14 ` [PULL 15/25] migration: skipped field is really obsolete Juan Quintela
2023-07-26 12:14 ` [PULL 16/25] docs/migration: Update postcopy bits Juan Quintela
2023-07-26 12:14 ` [PULL 17/25] migration: Update error description whenever migration fails Juan Quintela
2023-07-26 12:14 ` [PULL 18/25] migration: enforce multifd and postcopy preempt to be set before incoming Juan Quintela
2023-07-26 12:14 ` [PULL 19/25] qtest/migration-tests.c: use "-incoming defer" for postcopy tests Juan Quintela
2023-07-26 12:14 ` Juan Quintela [this message]
2023-07-26 12:14 ` [PULL 21/25] migration: Change qemu_file_transferred to noflush Juan Quintela
2023-07-26 12:14 ` [PULL 22/25] qemu_file: Make qemu_file_is_writable() static Juan Quintela
2023-07-26 12:14 ` [PULL 23/25] qemu-file: Simplify qemu_file_shutdown() Juan Quintela
2023-07-26 12:14 ` [PULL 24/25] qemu-file: Make qemu_file_get_error_obj() static Juan Quintela
2023-07-26 12:14 ` [PULL 25/25] migration/rdma: Split qemu_fopen_rdma() into input/output functions Juan Quintela
2023-07-26 16:23 ` [PULL 00/25] Migration 20230726 patches Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230726121459.1837-21-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=leobras@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).