qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Jeuk Kim <jeuk20.kim@gmail.com>
Cc: qemu-devel@nongnu.org, fam@euphon.net, hreitz@redhat.com,
	k.jensen@samsung.com, kwolf@redhat.com, pbonzini@redhat.com,
	qemu-block@nongnu.org, berrange@redhat.com,
	marcandre.lureau@redhat.com, marcel.apfelbaum@gmail.com,
	mst@redhat.com, philmd@linaro.org, thuth@redhat.com,
	lvivier@redhat.com, jeuk20.kim@samsung.com
Subject: Re: [PATCH v7 4/4] tests/qtest: Introduce tests for UFS
Date: Wed, 26 Jul 2023 15:35:30 -0400	[thread overview]
Message-ID: <20230726193530.GC822884@fedora> (raw)
In-Reply-To: <ebc4e4c699a43724319fda275a71db3ab6b6c0f7.1690348453.git.jeuk20.kim@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On Wed, Jul 26, 2023 at 02:30:53PM +0900, Jeuk Kim wrote:
> +static void *ufs_blk_test_setup(GString *cmd_line, void *arg)
> +{
> +    char *tmp_path = drive_create();
> +
> +    g_string_append_printf(cmd_line,
> +                           " -drive if=none,id=drv1,file=%s,"
> +                           "format=raw,auto-read-only=off "

The newer -blockdev syntax can be used:

-blockdev file,filename=%s,node-name=drv1

> +static void ufs_register_nodes(void)
> +{
> +    QOSGraphEdgeOptions edge_opts = {
> +        .before_cmd_line = "-drive id=drv0,if=none,file=null-co://,"
> +                           "file.read-zeroes=on,format=raw",

-blockdev null-co,node-name=drv0,read-zeroes=on

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2023-07-26 19:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  5:30 [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support Jeuk Kim
2023-07-26  5:30 ` [PATCH v7 1/4] hw/ufs: Initial commit for emulated Universal-Flash-Storage Jeuk Kim
2023-07-26  5:30 ` [PATCH v7 2/4] hw/ufs: Support for Query Transfer Requests Jeuk Kim
2023-07-26  5:30 ` [PATCH v7 3/4] hw/ufs: Support for UFS logical unit Jeuk Kim
2023-07-26  5:30 ` [PATCH v7 4/4] tests/qtest: Introduce tests for UFS Jeuk Kim
2023-07-26  7:21   ` Thomas Huth
2023-07-26  8:15     ` Jeuk Kim
2023-07-26 19:35   ` Stefan Hajnoczi [this message]
2023-07-26 19:36 ` [PATCH v7 0/4] hw/ufs: Add Universal Flash Storage (UFS) support Stefan Hajnoczi
2023-07-27  0:56   ` Jeuk Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230726193530.GC822884@fedora \
    --to=stefanha@redhat.com \
    --cc=berrange@redhat.com \
    --cc=fam@euphon.net \
    --cc=hreitz@redhat.com \
    --cc=jeuk20.kim@gmail.com \
    --cc=jeuk20.kim@samsung.com \
    --cc=k.jensen@samsung.com \
    --cc=kwolf@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).