From: Steffen Eiden <seiden@linux.ibm.com>
To: qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Janosch Frank <frankja@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
David Hildenbrand <david@redhat.com>,
Michael Mueller <mimu@linux.vnet.ibm.com>,
Marc Hartmayer <mhartmay@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>
Subject: [PATCH 0/3] KVM: s390: Enable AP instructions for pv-guests
Date: Thu, 27 Jul 2023 14:25:00 +0200 [thread overview]
Message-ID: <20230727122503.775084-1-seiden@linux.ibm.com> (raw)
This series enables general QEMU support for AP pass-through for Secure
Execution guests (pv-guests).
To enable AP-PT on pv-guests QEMU has to turn on the corresponding bits
in the KVM CPU-model[1] if the CPU firmware supports it. However, it
only makes sense to turn on AP-PT if the QEMU user enabled (general) AP
for that guest. If AP is turned on (ap=on) QEMU also turns on AP-PT for
secure execution guests(appv=on) if the CPU supports it.
The series consists of three patches:
1) update kvm-s390 header for this series
2) small cleanup for kvm_s390_set_attr()
refactor code to add ap_available()
3) Add UV_CALL CPU model enablement
There is **one** problem with the current implementation:
If the user does not enable AP in the cpu model QEMU produces the
following warning:
```
qemu-system-s390x: warning: 'appv' requires 'ap'.
```
During `check_consistency()` the model has appv=on and ap=offi, hence
the warning. However, appv is not turned on during the model
realization, as the code checks for AP in beforehand.
appv is in the default z16 model so that it is automatically enabled if
ap=on was specified.
I did not find a concept of dynamic defaults to model this behavior
(ap=on -> appv=on -> appvi=on). So I hope someone on the list can help
me and give some pointers on how to implement that.
Steffen
Steffen Eiden (3):
linux-headers: update asm-s390/kvm.h
target/s390x: refractor AP functionalities
target/s390x: AP-passthrough for PV guests
linux-headers/asm-s390/kvm.h | 21 +++++++
target/s390x/cpu_features.h | 1 +
target/s390x/cpu_features_def.h.inc | 4 ++
target/s390x/cpu_models.c | 2 +
target/s390x/gen-features.c | 4 ++
target/s390x/kvm/kvm.c | 91 ++++++++++++++++++++++++++---
6 files changed, 116 insertions(+), 7 deletions(-)
--
2.40.1
next reply other threads:[~2023-07-27 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 12:25 Steffen Eiden [this message]
2023-07-27 12:25 ` [PATCH 1/3] linux-headers: update asm-s390/kvm.h Steffen Eiden
2023-07-27 12:25 ` [PATCH 2/3] target/s390x: refractor AP functionalities Steffen Eiden
2023-07-28 10:36 ` Thomas Huth
2023-07-27 12:25 ` [PATCH 3/3] target/s390x: AP-passthrough for PV guests Steffen Eiden
2023-07-28 10:58 ` Thomas Huth
2023-07-28 9:39 ` [PATCH 0/3] KVM: s390: Enable AP instructions for pv-guests Steffen Eiden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727122503.775084-1-seiden@linux.ibm.com \
--to=seiden@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=mhartmay@linux.ibm.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).