From: Stefano Garzarella <sgarzare@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, Stefano Garzarella <sgarzare@redhat.com>
Subject: [PATCH v2 4/4] block/blkio: use blkio_set_int("fd") to check fd support
Date: Thu, 27 Jul 2023 18:10:20 +0200 [thread overview]
Message-ID: <20230727161020.84213-5-sgarzare@redhat.com> (raw)
In-Reply-To: <20230727161020.84213-1-sgarzare@redhat.com>
Setting the `fd` property fails with virtio-blk-* libblkio drivers
that do not support fd passing since
https://gitlab.com/libblkio/libblkio/-/merge_requests/208.
Getting the `fd` property, on the other hand, always succeeds for
virtio-blk-* libblkio drivers even when they don't support fd passing.
This patch switches to setting the `fd` property because it is a
better mechanism for probing fd passing support than getting the `fd`
property.
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
---
Notes:
v2:
- changed commit description [Stefan]
block/blkio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blkio.c b/block/blkio.c
index 72b46d61fd..8e7ce42c79 100644
--- a/block/blkio.c
+++ b/block/blkio.c
@@ -690,7 +690,7 @@ static int blkio_virtio_blk_connect(BlockDriverState *bs, QDict *options,
return -EINVAL;
}
- if (blkio_get_int(s->blkio, "fd", &fd) == 0) {
+ if (blkio_set_int(s->blkio, "fd", -1) == 0) {
fd_supported = true;
}
--
2.41.0
next prev parent reply other threads:[~2023-07-27 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 16:10 [PATCH v2 0/4] block/blkio: fix opening virtio-blk drivers Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 1/4] block/blkio: move blkio_connect() in the drivers functions Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 2/4] block/blkio: retry blkio_connect() if it fails using `fd` Stefano Garzarella
2023-07-27 16:10 ` [PATCH v2 3/4] block/blkio: fall back on using `path` when `fd` setting fails Stefano Garzarella
2023-07-27 16:10 ` Stefano Garzarella [this message]
2023-07-27 19:58 ` [PATCH v2 0/4] block/blkio: fix opening virtio-blk drivers Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230727161020.84213-5-sgarzare@redhat.com \
--to=sgarzare@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).