From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>,
Yonggang Luo <luoyonggang@gmail.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang
Date: Fri, 28 Jul 2023 16:27:47 +0200 [thread overview]
Message-ID: <20230728142748.305341-6-thuth@redhat.com> (raw)
In-Reply-To: <20230728142748.305341-1-thuth@redhat.com>
Clang on Windows does not seem to know the "gcc_struct" attribute
and emits a warning when we try to use it. Add an additional check
here with __has_attribute() to avoid this problem.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
include/qemu/compiler.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index a309f90c76..5065b4447c 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -22,7 +22,7 @@
#define QEMU_EXTERN_C extern
#endif
-#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__))
+#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) && !defined(__clang__)
# define QEMU_PACKED __attribute__((gcc_struct, packed))
#else
# define QEMU_PACKED __attribute__((packed))
--
2.39.3
next prev parent reply other threads:[~2023-07-28 14:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:27 [RFC PATCH 0/6] Use Clang for compiling in the 64-bit MSYS2 job Thomas Huth
2023-07-28 14:27 ` [RFC PATCH 1/6] gitlab: remove duplication between msys jobs Thomas Huth
2023-07-28 14:27 ` [RFC PATCH 2/6] ui/dbus: fix clang compilation issue Thomas Huth
2023-07-28 14:27 ` [RFC PATCH 3/6] util/oslib-win32: Fix compiling with Clang from MSYS2 Thomas Huth
2023-07-31 14:20 ` Philippe Mathieu-Daudé
2023-07-28 14:27 ` [RFC PATCH 4/6] hw/i386/intel_iommu: Fix VTD_IR_TableEntry for ms_struct layout Thomas Huth
2023-07-28 14:37 ` Daniel P. Berrangé
2023-07-28 16:39 ` Richard Henderson
2023-07-31 8:20 ` Thomas Huth
2023-07-31 20:26 ` Peter Xu
2023-07-31 20:53 ` Michael S. Tsirkin
2023-07-28 14:27 ` Thomas Huth [this message]
2023-07-28 15:13 ` [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang Peter Maydell
2023-07-31 9:10 ` Thomas Huth
2023-07-31 9:32 ` Daniel P. Berrangé
2023-07-31 12:04 ` Thomas Huth
2023-08-03 16:29 ` Daniel P. Berrangé
2023-07-31 14:10 ` Philippe Mathieu-Daudé
2023-07-31 17:25 ` Daniel P. Berrangé
2023-08-01 13:29 ` Philippe Mathieu-Daudé
2023-07-31 10:05 ` Peter Maydell
2023-07-31 12:05 ` Thomas Huth
2023-07-31 12:44 ` Daniel P. Berrangé
2023-08-01 13:49 ` Daniel P. Berrangé
2023-08-01 18:31 ` Thomas Huth
2023-07-31 12:57 ` Daniel P. Berrangé
2023-07-31 14:07 ` Philippe Mathieu-Daudé
2023-07-28 14:27 ` [RFC PATCH 6/6] gitlab-ci.d/windows: Use Clang for compiling in the 64-bit MSYS2 job Thomas Huth
2023-07-31 14:23 ` Philippe Mathieu-Daudé
2023-07-31 14:43 ` Thomas Huth
2023-08-01 13:30 ` Philippe Mathieu-Daudé
2023-08-01 13:35 ` [RFC PATCH 0/6] " Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728142748.305341-6-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).