From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
Gautam Dawar <gdawar@xilinx.com>,
si-wei.liu@oracle.com, Zhu Lingshan <lingshan.zhu@intel.com>,
Stefano Garzarella <sgarzare@redhat.com>,
Parav Pandit <parav@mellanox.com>, Cindy Lu <lulu@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Laurent Vivier <lvivier@redhat.com>,
Shannon Nelson <snelson@pensando.io>,
Lei Yang <leiyang@redhat.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: [PATCH 4/7] vdpa: add stub vhost_vdpa_should_enable
Date: Fri, 28 Jul 2023 19:20:25 +0200 [thread overview]
Message-ID: <20230728172028.2074052-5-eperezma@redhat.com> (raw)
In-Reply-To: <20230728172028.2074052-1-eperezma@redhat.com>
To restore the device at the destination of a live migration we send the
commands through control virtqueue. For a device to read CVQ it must
have received the DRIVER_OK status bit.
However this opens a window where the device could start receiving
packets in rx queue 0 before it receives the RSS configuration. To
avoid that, we will not send vring_enable until all configuration is
used by the device.
Add vhost-vdpa net vhost_vdpa_should_enable. Do not change the behavior
in this commit, only introduce the op.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
net/vhost-vdpa.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 9795306742..3d7dc3e5c0 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vdpa.c
@@ -1255,6 +1255,15 @@ static const VhostShadowVirtqueueOps vhost_vdpa_net_svq_ops = {
.avail_handler = vhost_vdpa_net_handle_ctrl_avail,
};
+static bool vhost_vdpa_should_enable(const struct vhost_vdpa *v)
+{
+ return true;
+}
+
+static const VhostVDPAVirtIOOps vhost_vdpa_virtio_net_ops = {
+ .should_enable = vhost_vdpa_should_enable,
+};
+
/**
* Probe if CVQ is isolated
*
@@ -1378,6 +1387,7 @@ static NetClientState *net_vhost_vdpa_init(NetClientState *peer,
s->vhost_vdpa.shadow_vqs_enabled = svq;
s->vhost_vdpa.iova_range = iova_range;
s->vhost_vdpa.shadow_data = svq;
+ s->vhost_vdpa.virtio_ops = &vhost_vdpa_virtio_net_ops;
if (queue_pair_index == 0) {
vhost_vdpa_net_valid_svq_features(features,
&s->vhost_vdpa.migration_blocker);
--
2.39.3
next prev parent reply other threads:[~2023-07-28 18:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 17:20 [PATCH 0/7] Enable vdpa net migration with features depending on CVQ Eugenio Pérez
2023-07-28 17:20 ` [PATCH 1/7] vdpa: export vhost_vdpa_set_vring_ready Eugenio Pérez
2023-07-28 17:20 ` [PATCH 2/7] vdpa: add should_enable op Eugenio Pérez
2023-07-28 17:20 ` [PATCH 3/7] vdpa: use virtio_ops->should_enable at vhost_vdpa_set_vrings_ready Eugenio Pérez
2023-07-28 17:20 ` Eugenio Pérez [this message]
2023-07-28 17:20 ` [PATCH 5/7] vdpa: delay enable of data vqs Eugenio Pérez
2023-07-28 17:20 ` [PATCH 6/7] vdpa: enable cvq svq if data vq are shadowed Eugenio Pérez
2023-07-28 17:20 ` [PATCH 7/7] vdpa: remove net cvq migration blocker Eugenio Pérez
2023-07-31 6:41 ` [PATCH 0/7] Enable vdpa net migration with features depending on CVQ Jason Wang
2023-07-31 10:15 ` Eugenio Perez Martin
2023-08-01 3:48 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728172028.2074052-5-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).