qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: virtio-blk using a single iothread
Date: Mon, 31 Jul 2023 11:51:06 -0400	[thread overview]
Message-ID: <20230731155106.GB1253041@fedora> (raw)
In-Reply-To: <d8028f17-8d33-790b-8d3e-fa1170108774@grimberg.me>

[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]

On Sun, Jun 11, 2023 at 03:27:57PM +0300, Sagi Grimberg wrote:
> Maybe I'm doing something wrong? Didn't expect to find a regression
> against mainline on the default setup.

Hi Sagi,
I ran the latest branch against ed8ad9728a where it forked off master.
master achieves fewer IOPS.

It looks like the regression you saw was solved by the changes I made
last week.

Both "master" and "modified" are running with 1 IOThread:

                           IOPS
			  ------
randread 4k 64 master-1   213504
randread 4k 64 master-2   212650
randread 4k 64 master-3   211699
randread 4k 64 master-4   211940
randread 4k 64 master-5   214110
randread 4k 64 modified-1 234708
randread 4k 64 modified-2 236014
randread 4k 64 modified-3 235328
randread 4k 64 modified-4 235742

The improvement is around 10%.

You can find the benchmark configuration and raw data here:
https://gitlab.com/stefanha/virt-playbooks/-/tree/1a464c0676fe9133fb244d8a2dd1439001c7bc42

The configuration is in go.yml, plays/benchmark.yml, files/test.xml.j2,
and files/fio.sh.

The raw data is in notebook/fio-output/ and you can explore the Jupyter
notebook by running notebook/go.sh.

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

      parent reply	other threads:[~2023-07-31 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08  7:40 virtio-blk using a single iothread Sagi Grimberg
2023-06-08 16:08 ` Stefan Hajnoczi
2023-06-11 12:27   ` Sagi Grimberg
2023-06-21 12:23     ` Stefan Hajnoczi
2023-07-27 15:11     ` Stefan Hajnoczi
2023-07-31 15:51     ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731155106.GB1253041@fedora \
    --to=stefanha@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).