From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 866C4C04A94 for ; Mon, 31 Jul 2023 21:35:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qQaWi-0005y1-Bp; Mon, 31 Jul 2023 17:34:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQaWe-0005xq-J0 for qemu-devel@nongnu.org; Mon, 31 Jul 2023 17:34:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qQaWd-0007Dd-5z for qemu-devel@nongnu.org; Mon, 31 Jul 2023 17:34:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690839237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7RaNBI6rmSgDQ/p+0u44WYWfipJQLQNF2UOLsc5T27k=; b=Qg/pZW+4weUQe6EzGHwlOeK4SsqyBnXFDDgxm4dNMylb5sdXNfiVNZNC2OBhYWTZ5vWPwA 5MmDG873nvUszKVoYrWDCu7oIRL4RuklxkUFspFKs2VIQfNA8vmpxC3i01CKphumEDyYdh UZvH0Ziu3OulfOqynK1ZG/AvV75n580= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-mrY7Vr9uMnmPh2Oihm8KBA-1; Mon, 31 Jul 2023 17:33:56 -0400 X-MC-Unique: mrY7Vr9uMnmPh2Oihm8KBA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-314134f403fso2459227f8f.2 for ; Mon, 31 Jul 2023 14:33:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690839235; x=1691444035; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7RaNBI6rmSgDQ/p+0u44WYWfipJQLQNF2UOLsc5T27k=; b=HKUJiOhHKCwHt4gs+J6lFLFYK8WxajBvA8Wk1IxcMqSMXdIFGHV9qiXEgrq4zoy2ST O2rypsYWz91FAvcatlF5qOWAUIAK8MLXWvI34kc7DkjQncd7EBh4y1tZBDtOP+d0O+SR McsizKcrd3v285T5APdKTUdTKxeJ30HwYFarqAu6jbtoZ2wEtFH+M66k1x4w5ySE7g1D dxy4JzOoUHYXzns3Fma4kWMlhbuD4/pyiMfdGnbJ+2OfeAcg9dF6+MYjmZYguGY4GELv SBjVK90iAEttNfYb1mJEEFkrLHY3upj0S+TXm0gikN0Zf+bNpOIIIleFm+yJzDjMcQFM U+BQ== X-Gm-Message-State: ABy/qLZ4BAu8fqyr+jGOs50CkrF7Ys0oI9J82CHR+tQmLqiTf+xVjLnC D4l68FbomF9VClC/tR6yw8iZlQIaRgAr0SNHjwPbi8lUrv9QsR+fW3/byTKcMiNgqDxRRpoA3d/ LevYeWrzBJf+y9s8= X-Received: by 2002:adf:ee91:0:b0:317:6be2:f444 with SMTP id b17-20020adfee91000000b003176be2f444mr775729wro.49.1690839235271; Mon, 31 Jul 2023 14:33:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlHcpjszLVqFylH1zCms7R0ZXVG+68YIUyxgADLBbo5hwKg+QDAGEsaP020c80X8aiInSNd3/Q== X-Received: by 2002:adf:ee91:0:b0:317:6be2:f444 with SMTP id b17-20020adfee91000000b003176be2f444mr775710wro.49.1690839235003; Mon, 31 Jul 2023 14:33:55 -0700 (PDT) Received: from redhat.com ([2.52.21.81]) by smtp.gmail.com with ESMTPSA id k14-20020adfe3ce000000b00317643a93f4sm14127145wrm.96.2023.07.31.14.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 14:33:54 -0700 (PDT) Date: Mon, 31 Jul 2023 17:33:49 -0400 From: "Michael S. Tsirkin" To: Peter Xu Cc: Xiaoyao Li , Paolo Bonzini , Sean Christopherson , David Hildenbrand , Igor Mammedov , Marcel Apfelbaum , Richard Henderson , Marcelo Tosatti , Markus Armbruster , Eric Blake , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Chao Peng , Michael Roth , isaku.yamahata@gmail.com, qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private() Message-ID: <20230731173132-mutt-send-email-mst@kernel.org> References: <20230731162201.271114-1-xiaoyao.li@intel.com> <20230731162201.271114-5-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Jul 31, 2023 at 05:23:55PM -0400, Peter Xu wrote: > On Mon, Jul 31, 2023 at 12:21:46PM -0400, Xiaoyao Li wrote: > > +bool memory_region_can_be_private(MemoryRegion *mr) > > +{ > > + return mr->ram_block && mr->ram_block->gmem_fd >= 0; > > +} > > This is not really MAP_PRIVATE, am I right? If so, is there still chance > we rename it (it seems to be also in the kernel proposal all across..)? > > I worry it can be very confusing in the future against MAP_PRIVATE / > MAP_SHARED otherwise. > > Thanks, It is - kernel calls this "map shared" but unfortunately qemu calls this just "shared". Maybe e.g. "protect_shared" would be a better name for qemu? -- MST