From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, qemu-s390x@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-stable@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 10/10] target/m68k: Fix semihost lseek offset computation
Date: Tue, 1 Aug 2023 23:54:21 +0200 [thread overview]
Message-ID: <20230801215421.60133-11-philmd@linaro.org> (raw)
In-Reply-To: <20230801215421.60133-1-philmd@linaro.org>
From: Peter Maydell <peter.maydell@linaro.org>
The arguments for deposit64 are (value, start, length, fieldval); this
appears to have thought they were (value, fieldval, start,
length). Reorder the parameters to match the actual function.
Cc: qemu-stable@nongnu.org
Fixes: 950272506d ("target/m68k: Use semihosting/syscalls.h")
Reported-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230801154519.3505531-1-peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/m68k/m68k-semi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c
index 88ad9ba814..239f6e44e9 100644
--- a/target/m68k/m68k-semi.c
+++ b/target/m68k/m68k-semi.c
@@ -166,7 +166,7 @@ void do_m68k_semihosting(CPUM68KState *env, int nr)
GET_ARG64(2);
GET_ARG64(3);
semihost_sys_lseek(cs, m68k_semi_u64_cb, arg0,
- deposit64(arg2, arg1, 32, 32), arg3);
+ deposit64(arg2, 32, 32, arg1), arg3);
break;
case HOSTED_RENAME:
--
2.38.1
next prev parent reply other threads:[~2023-08-01 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 21:54 [PULL 00/10] Misc fixes for 2023-08-01 Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 01/10] hw/xen: fix off-by-one in xen_evtchn_set_gsi() Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 02/10] i386/xen: consistent locking around Xen singleshot timers Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 03/10] hw/xen: prevent guest from binding loopback event channel to itself Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 04/10] ui/dbus: fix win32 compilation when !opengl Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 05/10] ui/dbus: fix clang compilation issue Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 06/10] misc: Fix some typos in documentation and comments Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 07/10] tests/migration: Add -fno-stack-protector Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 08/10] target/nios2: Pass semihosting arg to exit Philippe Mathieu-Daudé
2023-08-01 21:54 ` [PULL 09/10] target/nios2: Fix semihost lseek offset computation Philippe Mathieu-Daudé
2023-08-01 21:54 ` Philippe Mathieu-Daudé [this message]
2023-08-02 15:14 ` [PULL 00/10] Misc fixes for 2023-08-01 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801215421.60133-11-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).