qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [PULL 1/9] util/oslib-win32: Fix compiling with Clang from MSYS2
Date: Thu,  3 Aug 2023 13:09:24 +0200	[thread overview]
Message-ID: <20230803110932.341091-2-thuth@redhat.com> (raw)
In-Reply-To: <20230803110932.341091-1-thuth@redhat.com>

Clang complains:

../util/oslib-win32.c:483:56: error: omitting the parameter name in a
 function definition is a C2x extension [-Werror,-Wc2x-extensions]
win32_close_exception_handler(struct _EXCEPTION_RECORD*,
                                                       ^
Fix it by adding parameter names.

Message-Id: <20230728142748.305341-4-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 util/oslib-win32.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/util/oslib-win32.c b/util/oslib-win32.c
index 429542face..19a0ea7fbe 100644
--- a/util/oslib-win32.c
+++ b/util/oslib-win32.c
@@ -480,8 +480,9 @@ int qemu_bind_wrap(int sockfd, const struct sockaddr *addr,
 }
 
 EXCEPTION_DISPOSITION
-win32_close_exception_handler(struct _EXCEPTION_RECORD*,
-                              void*, struct _CONTEXT*, void*)
+win32_close_exception_handler(struct _EXCEPTION_RECORD *exception_record,
+                              void *registration, struct _CONTEXT *context,
+                              void *dispatcher)
 {
     return EXCEPTION_EXECUTE_HANDLER;
 }
-- 
2.39.3



  reply	other threads:[~2023-08-03 11:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03 11:09 [PULL 0/9] Fixes for 8.1-rc3 Thomas Huth
2023-08-03 11:09 ` Thomas Huth [this message]
2023-08-03 11:09 ` [PULL 2/9] gitlab: remove duplication between msys jobs Thomas Huth
2023-08-03 11:09 ` [PULL 3/9] gitlab: print timestamps during windows " Thomas Huth
2023-08-03 11:09 ` [PULL 4/9] gitlab: always use updated msys installer Thomas Huth
2023-08-03 11:09 ` [PULL 5/9] gitlab: drop $CI_PROJECT_DIR from cache path Thomas Huth
2023-08-03 11:09 ` [PULL 6/9] gitlab: always populate cache for windows msys jobs Thomas Huth
2023-08-03 11:09 ` [PULL 7/9] configure: support passthrough of -Dxxx args to meson Thomas Huth
2023-08-03 11:09 ` [PULL 8/9] gitlab: disable optimization and debug symbols in msys build Thomas Huth
2023-08-03 11:09 ` [PULL 9/9] gitlab: disable FF_SCRIPT_SECTIONS on msys jobs Thomas Huth
2023-08-03 16:21 ` [PULL 0/9] Fixes for 8.1-rc3 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230803110932.341091-2-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).