[PATCH] Fix scripts/checkpatch.py style failures.

[PATCH] Fix scripts/checkpatch.py style failures.

[Nathan Egge]

From: "Nathan Egge" <negge@xiph.org>

Signed-off-by: Nathan Egge <negge@xiph.org>
---
 linux-user/syscall.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 95727a816a..38ab2201e2 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -863,8 +863,8 @@ abi_long do_brk(abi_ulong brk_val)
     if (new_host_brk_page > brk_page) {
         new_alloc_size = new_host_brk_page - brk_page;
         mapped_addr = get_errno(target_mmap(brk_page, new_alloc_size,
-                                        PROT_READ|PROT_WRITE,
-                                        MAP_ANON|MAP_PRIVATE, 0, 0));
+                                        PROT_READ | PROT_WRITE,
+                                        MAP_ANON | MAP_PRIVATE, 0, 0));
     } else {
         new_alloc_size = 0;
         mapped_addr = brk_page;
@@ -6128,8 +6128,8 @@ static abi_long write_ldt(CPUX86State *env,
     if (!ldt_table) {
         env->ldt.base = target_mmap(0,
                                     TARGET_LDT_ENTRIES * TARGET_LDT_ENTRY_SIZE,
-                                    PROT_READ|PROT_WRITE,
-                                    MAP_ANONYMOUS|MAP_PRIVATE, -1, 0);
+                                    PROT_READ | PROT_WRITE,
+                                    MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
         if (env->ldt.base == -1)
             return -TARGET_ENOMEM;
         memset(g2h_untagged(env->ldt.base), 0,
-- 
2.35.1

Re: [PATCH] Fix scripts/checkpatch.py style failures.

[Michael Tokarev]

Applied to my trivial-patches tree (for 8.2).

/mjt

Re: [PATCH] Fix scripts/checkpatch.py style failures.

[Michael Tokarev]

05.08.2023 15:51, Nathan Egge пишет:
> From: "Nathan Egge" <negge@xiph.org>
> 
> Signed-off-by: Nathan Egge <negge@xiph.org>

This needs at least some meaningful subject prefix.
With the subject like it is now, it feels like the
patch is about fixing checkpatch.py script itself.

Something like:

  linux-user/syscall.c: fix coding-style issue (space-around-or)

I think one of the two places should be fixed in a
patch which touches this place in tcg-next series
instead of separately.

/mjt

Re: [PATCH] Fix scripts/checkpatch.py style failures.

[Peter Maydell]

On Sat, 5 Aug 2023 at 17:44, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 05.08.2023 15:51, Nathan Egge пишет:
> > From: "Nathan Egge" <negge@xiph.org>
> >
> > Signed-off-by: Nathan Egge <negge@xiph.org>
>
> This needs at least some meaningful subject prefix.
> With the subject like it is now, it feels like the
> patch is about fixing checkpatch.py script itself.
>
> Something like:
>
>   linux-user/syscall.c: fix coding-style issue (space-around-or)
>
> I think one of the two places should be fixed in a
> patch which touches this place in tcg-next series
> instead of separately.

Also, this specific area of code (brk handling) is currently
being worked on quite heavily. I'm pretty sure there's a patchset
on list which touches these specific lines of code (and might
well have fixed the style issue in passing). So we should hold
off on the purely coding-style fixes here until after the dust
has settled on those changes.

thanks
-- PMM