qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH for-8.2] configure: fix container_hosts misspellings and duplications
@ 2023-08-07  9:22 Paolo Bonzini
  2023-08-07 16:02 ` Richard Henderson
  2023-08-10  9:22 ` Philippe Mathieu-Daudé
  0 siblings, 2 replies; 3+ messages in thread
From: Paolo Bonzini @ 2023-08-07  9:22 UTC (permalink / raw)
  To: qemu-devel; +Cc: alex.bennee

container_hosts is matched against $cpu, so it must contain QEMU
canonical architecture names, not Debian architecture names.
Also do not set $container_hosts inside the loop, since it is
already set before.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/configure b/configure
index f5a6624ddf1..0496189787a 100755
--- a/configure
+++ b/configure
@@ -1347,7 +1347,7 @@ probe_target_compiler() {
     sh4) container_hosts=x86_64 ;;
     sparc64) container_hosts=x86_64 ;;
     tricore) container_hosts=x86_64 ;;
-    x86_64) container_hosts="aarch64 ppc64el x86_64" ;;
+    x86_64) container_hosts="aarch64 ppc64le x86_64" ;;
     xtensa*) container_hosts=x86_64 ;;
   esac
 
@@ -1458,7 +1458,6 @@ probe_target_compiler() {
         container_cross_prefix=x86_64-linux-gnu-
         ;;
       xtensa*)
-        container_hosts=x86_64
         container_image=debian-xtensa-cross
 
         # default to the dc232b cpu
-- 
2.41.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH for-8.2] configure: fix container_hosts misspellings and duplications
  2023-08-07  9:22 [PATCH for-8.2] configure: fix container_hosts misspellings and duplications Paolo Bonzini
@ 2023-08-07 16:02 ` Richard Henderson
  2023-08-10  9:22 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2023-08-07 16:02 UTC (permalink / raw)
  To: Paolo Bonzini, qemu-devel; +Cc: alex.bennee

On 8/7/23 02:22, Paolo Bonzini wrote:
> container_hosts is matched against $cpu, so it must contain QEMU
> canonical architecture names, not Debian architecture names.
> Also do not set $container_hosts inside the loop, since it is
> already set before.
> 
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   configure | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH for-8.2] configure: fix container_hosts misspellings and duplications
  2023-08-07  9:22 [PATCH for-8.2] configure: fix container_hosts misspellings and duplications Paolo Bonzini
  2023-08-07 16:02 ` Richard Henderson
@ 2023-08-10  9:22 ` Philippe Mathieu-Daudé
  1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-08-10  9:22 UTC (permalink / raw)
  To: Paolo Bonzini, qemu-devel; +Cc: alex.bennee

On 7/8/23 11:22, Paolo Bonzini wrote:
> container_hosts is matched against $cpu, so it must contain QEMU
> canonical architecture names, not Debian architecture names.
> Also do not set $container_hosts inside the loop, since it is
> already set before.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-10  9:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07  9:22 [PATCH for-8.2] configure: fix container_hosts misspellings and duplications Paolo Bonzini
2023-08-07 16:02 ` Richard Henderson
2023-08-10  9:22 ` Philippe Mathieu-Daudé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).