From: Igor Mammedov <imammedo@redhat.com>
To: Zhao Liu <zhao1.liu@intel.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
Zhao Liu <zhao1.liu@linux.intel.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Ani Sinha <anisinha@redhat.com>,
qemu-devel@nongnu.org, Zhenyu Wang <zhenyu.z.wang@intel.com>
Subject: Re: [PATCH v2 2/3] hw/smbios: Fix thread count in type4
Date: Mon, 7 Aug 2023 12:11:29 +0200 [thread overview]
Message-ID: <20230807121129.30e6fe1e@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <ddfe932b-57b7-8f48-03aa-82e1964dda2a@tls.msk.ru>
On Mon, 7 Aug 2023 13:06:47 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:
> 07.08.2023 12:56, Igor Mammedov wrote:
> > On Sat, 5 Aug 2023 09:00:41 +0300
> > Michael Tokarev <mjt@tls.msk.ru> wrote:
[...]
> The whole thing - provided the preparational patch a1d027be95
> "machine: Add helpers to get cores/threads per socket" is also
> picked up - applies cleanly and in a stright-forward way to 8.0
> and even to 7.2, and passes the usual qemu testsuite. Sure thing
> since the issues weren't noticed before, the testsuite does not
> cover this area. It'd be nice to have some verifier to check if
> the whole thing actually works after applying the patchset.
Zhao Liu,
can you help us out with adding test cases to cover the code
you are touching?
[...]
next prev parent reply other threads:[~2023-08-07 10:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 9:29 [PATCH v2 0/3] hw/smbios: Cleanup topology related variables Zhao Liu
2023-06-01 9:29 ` [PATCH v2 1/3] hw/smbios: Fix smbios_smp_sockets caculation Zhao Liu
2023-06-07 14:35 ` Igor Mammedov
2023-06-08 2:48 ` Zhao Liu
2023-06-01 9:29 ` [PATCH v2 2/3] hw/smbios: Fix thread count in type4 Zhao Liu
2023-06-07 14:49 ` Igor Mammedov
2023-06-08 2:51 ` Zhao Liu
2023-06-08 8:28 ` Igor Mammedov
2023-08-05 5:58 ` Michael Tokarev
2023-08-05 6:00 ` Michael Tokarev
2023-08-07 9:56 ` Igor Mammedov
2023-08-07 10:06 ` Michael Tokarev
2023-08-07 10:11 ` Igor Mammedov [this message]
2023-08-07 14:31 ` Zhao Liu
2023-08-09 13:39 ` Igor Mammedov
2023-06-01 9:29 ` [PATCH v2 3/3] hw/smbios: Fix core " Zhao Liu
2023-06-07 14:51 ` Igor Mammedov
2023-06-08 2:52 ` Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807121129.30e6fe1e@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=anisinha@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).