From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C71FDC001DF for ; Tue, 8 Aug 2023 14:44:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qTNwu-0007QP-J3; Tue, 08 Aug 2023 10:44:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTNws-0007PR-0E for qemu-devel@nongnu.org; Tue, 08 Aug 2023 10:44:38 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qTNwp-0008NW-0R for qemu-devel@nongnu.org; Tue, 08 Aug 2023 10:44:37 -0400 Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RKwps3YcDz6J6vV; Tue, 8 Aug 2023 22:40:53 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 15:44:31 +0100 Date: Tue, 8 Aug 2023 15:44:30 +0100 To: Michael Tokarev CC: Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , "Li Zhijian" , , Subject: Re: [PATCH v3] hw/cxl: Fix CFMW config memory leak Message-ID: <20230808154430.0000291e@Huawei.com> In-Reply-To: <0adbfa43-719c-6d8e-9ec9-5d4a402be384@tls.msk.ru> References: <20230531060706.11840-1-lizhijian@cn.fujitsu.com> <5ac2e71e-7bc0-ee84-fce2-8d0b6e137a3e@linaro.org> <20230531120823.00001a6c@Huawei.com> <0adbfa43-719c-6d8e-9ec9-5d4a402be384@tls.msk.ru> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, 5 Aug 2023 08:46:29 +0300 Michael Tokarev wrote: > 31.05.2023 14:08, Jonathan Cameron via wrote: > > On Wed, 31 May 2023 09:51:43 +0200 > > Philippe Mathieu-Daud=E9 wrote: > > =20 > >> On 31/5/23 08:07, Li Zhijian wrote: =20 > >>> Allocate targets and targets[n] resources when all sanity checks are > >>> passed to avoid memory leaks. > >>> > >>> Suggested-by: Philippe Mathieu-Daud=E9 > >>> Signed-off-by: Li Zhijian > >>> --- > >>> V3: allocte further resource when we can't fail # Philippe =20 > >> > >> Thanks for the v3! > >> > >> Reviewed-by: Philippe Mathieu-Daud=E9 =20 > >=20 > > Thanks. I've added this near the top of my queue so will send > > it out along with other similar fixes as a series for Michael > > to consider picking up. =20 >=20 > Hi! >=20 > Has this been forgotten? Is it still needed? >=20 > /mjt >=20 Sorry, I'm running a bit behind. Have this one a few other fixes still queued up - I didn't consider any of them particularly critical for the release so wasn't rushing. I'll aim to get them out as a series soon though so they are available for start of next cycle if not for slipping in before the release. Jonathan