* [PATCH for-8.1] tests/tcg: Disable filename test for info proc mappings
@ 2023-08-08 23:49 Richard Henderson
2023-08-09 10:59 ` Ilya Leoshkevich
0 siblings, 1 reply; 2+ messages in thread
From: Richard Henderson @ 2023-08-08 23:49 UTC (permalink / raw)
To: qemu-devel; +Cc: iii, alex.bennee
This test fails when host page size != guest page size,
because qemu may not be able to directly map the file.
Fixes: a6341482695 ("tests/tcg: Add a test for info proc mappings")
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tests/tcg/multiarch/gdbstub/test-proc-mappings.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
index 7b596ac21b..5e3e5a2fb7 100644
--- a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
+++ b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
@@ -33,7 +33,8 @@ def run_test():
return
raise
report(isinstance(mappings, str), "Fetched the mappings from the inferior")
- report("/sha1" in mappings, "Found the test binary name in the mappings")
+ # Broken with host page size > guest page size
+ # report("/sha1" in mappings, "Found the test binary name in the mappings")
def main():
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH for-8.1] tests/tcg: Disable filename test for info proc mappings
2023-08-08 23:49 [PATCH for-8.1] tests/tcg: Disable filename test for info proc mappings Richard Henderson
@ 2023-08-09 10:59 ` Ilya Leoshkevich
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Leoshkevich @ 2023-08-09 10:59 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: alex.bennee
On Tue, 2023-08-08 at 16:49 -0700, Richard Henderson wrote:
> This test fails when host page size != guest page size,
> because qemu may not be able to directly map the file.
>
> Fixes: a6341482695 ("tests/tcg: Add a test for info proc mappings")
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tests/tcg/multiarch/gdbstub/test-proc-mappings.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> index 7b596ac21b..5e3e5a2fb7 100644
> --- a/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> +++ b/tests/tcg/multiarch/gdbstub/test-proc-mappings.py
> @@ -33,7 +33,8 @@ def run_test():
> return
> raise
> report(isinstance(mappings, str), "Fetched the mappings from the
> inferior")
> - report("/sha1" in mappings, "Found the test binary name in the
> mappings")
> + # Broken with host page size > guest page size
> + # report("/sha1" in mappings, "Found the test binary name in the
> mappings")
>
>
> def main():
I'll try to find a way to check host/guest page sizes in Python for
8.2. I think it's fine to disable the check for 8.1.
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-09 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 23:49 [PATCH for-8.1] tests/tcg: Disable filename test for info proc mappings Richard Henderson
2023-08-09 10:59 ` Ilya Leoshkevich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).