From: Andrew Jones <ajones@ventanamicro.com>
To: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
alistair.francis@wdc.com, bmeng@tinylab.org,
liweiwei@iscas.ac.cn, zhiwei_liu@linux.alibaba.com,
palmer@rivosinc.com
Subject: Re: [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids()
Date: Thu, 10 Aug 2023 09:51:12 +0200 [thread overview]
Message-ID: <20230810-d3fe7bd8e11c07aa7e890bec@orel> (raw)
In-Reply-To: <93cf5366-9723-3c08-6ce1-d0dbd1f4a76f@ventanamicro.com>
On Wed, Aug 09, 2023 at 07:16:00PM -0300, Daniel Henrique Barboza wrote:
> Drew,
>
> On 8/3/23 09:05, Andrew Jones wrote:
> > On Thu, Aug 03, 2023 at 08:36:57AM -0300, Daniel Henrique Barboza wrote:
...
> > So, I think we need a helper that has a switch on the KVM register type
> > and provides the right sized buffer for each case.
>
> Is this a suggestion to do this right now in this patch? I didn't understand
> whether you're ok with the fix as is for 8.1 or if you want more things done
> right away.
>
The fix looks good for 8.1. Using target_ulong looks right to me for all
KVM ULONG-sized registers. When we try to build an API which provides the
right sized buffers (which is future work), we'll want to use target_ulong
there too.
Thanks,
drew
next prev parent reply other threads:[~2023-08-10 7:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 18:00 [PATCH] target/riscv/kvm.c: fix mvendorid size in vcpu_set_machine_ids() Daniel Henrique Barboza
2023-08-03 9:29 ` Andrew Jones
2023-08-03 11:36 ` Daniel Henrique Barboza
2023-08-03 12:05 ` Andrew Jones
2023-08-03 13:04 ` Daniel Henrique Barboza
2023-08-09 22:16 ` Daniel Henrique Barboza
2023-08-10 7:51 ` Andrew Jones [this message]
2023-08-10 17:01 ` Alistair Francis
2023-08-11 11:29 ` Daniel Henrique Barboza
2023-08-10 7:47 ` Andrew Jones
2023-08-10 16:57 ` Alistair Francis
2023-08-10 16:59 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810-d3fe7bd8e11c07aa7e890bec@orel \
--to=ajones@ventanamicro.com \
--cc=alistair.francis@wdc.com \
--cc=bmeng@tinylab.org \
--cc=dbarboza@ventanamicro.com \
--cc=liweiwei@iscas.ac.cn \
--cc=palmer@rivosinc.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).